957037 - Pull in Android's ProxySelectorImpl code so we can bypass creating Uri objects

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: Custom proxy selector v0.1

Even after fixing bug XXX, GeckoAppShell.getProxyForURI still takes up ~230ms when loading cnn.com, mainly because we need to create Uri objects. We can avoid this. We already pass the raw scheme and host to getProxyForURI and Android just extracts those from the Uri we make.

This patch pulls in the implementation with a new entry point, which takes a scheme and host directly. Initial profiles show that getProxyForURI is now in the ~25ms range when loading cnn.com.

What's the best way to test this, especially on gingerbread up to kitkat?
I assume we should keep the Android source license since much of the file is unchanged.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 8356457 [details] [diff] [review]
Custom proxy selector v0.1

Review of attachment 8356457 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/util/ProxySelector.java
@@ +11,5 @@
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */

just add a comment as to where this code came from

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: Custom proxy selector v0.2

Added a comment

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 8356739 [details] [diff] [review]
Custom proxy selector v0.2

Review of attachment 8356739 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/util/ProxySelector.java
@@ +13,5 @@
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +
> +// This code is based on /libcore/luni/src/main/java/java/net/ProxySelectorImpl.java

// This code is based on AOSP's /libcore....

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/fx-team/rev/0b085ae22f9d

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0b085ae22f9d