Closed
Bug 957090
Opened 10 years ago
Closed 3 years ago
Cleanup repeated ViewHelper.set*() calls on PropertyAnimations
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: lucasr, Unassigned)
References
Details
Suggestion from wesj in bug 942862: > @@ +331,5 @@ > > + // the animation starts, so we shift these items to the right so that they don't > > + // appear to move initially. > > + ViewHelper.setTranslationX(mTitle, width); > > + ViewHelper.setTranslationX(mFavicon, width); > > + ViewHelper.setTranslationX(mSiteSecurity, width); > > Separate bug, but these repeated calls could probably be wrapped in > something prettier. i.e. > > prepareTranslate(PropertyAnimator anim, Integer start, int end, View > views...) { > for (View v : views) { > anim.attach(v, PropertyAnimation.Property.TRANSLATION_X, end); > if (start != null) > ViewHelper.setTranslationX(v, start); > } > }
Comment 1•3 years ago
|
||
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Assignee | ||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•