Closed Bug 957162 Opened 6 years ago Closed 6 years ago

Marionette waits should include the timeout duration when throwing TimeoutException

Categories

(Testing :: Marionette, defect)

defect
Not set

Tracking

(firefox27 fixed, firefox28 fixed, firefox29 fixed)

RESOLVED FIXED
mozilla29
Tracking Status
firefox27 --- fixed
firefox28 --- fixed
firefox29 --- fixed

People

(Reporter: davehunt, Assigned: ato)

Details

Attachments

(1 file)

Currently if a Wait fails a TimeoutException is thrown with no message:

TEST-UNEXPECTED-FAIL | test_homescreen_edit_mode.py test_homescreen_edit_mode.TestEditMode.test_access_and_leave_edit_mode | TimeoutException: None

We should at least include the timeout duration:

TEST-UNEXPECTED-FAIL | test_homescreen_edit_mode.py test_homescreen_edit_mode.TestEditMode.test_access_and_leave_edit_mode | TimeoutException: Timed out after 0.1 seconds

This can be a useful indication when looking at failures that an inappropriate timeout value is being used.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Attached a patch.
Attachment #8357185 - Flags: review?(dave.hunt)
Attachment #8357185 - Flags: review?(dave.hunt) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ed17bd48a68b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
I pressed my luck a bit too much on this. Backed out from b2g26 for test failures that I've already gone too far down the rabbit hole trying to fix.

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/b01ca2847626
You need to log in before you can comment on or make changes to this bug.