957163 - Improve waiting in the keyboard app object logic

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[Zac C (:zac)]

Is a bit flaky on device, looks like the keyboard is responding very slowly.

Comment 1

[Zac C (:zac)]

Attachment: github pr

This failure exposed some issues in our Keyboard app object.
This PR addresses:

- More comments explaining things
- wait_for_displayed instead of condition which gives better exception messages
- Explicit waits after changing layouts
- Slight simplification of change layout logic
- Explicit wait after tapping space/upper case
- Bug wlach found where key after space would not work

Comment 2

[Zac C (:zac)]

also I did test this on v1.3 :)

Comment 3

[William Lachance (:wlach)]

Hmm, the test in bug 917404 is still hanging for me with this change. Before it would hang after the space was entered. Now nothing is being entered. I'll attach the test here as well, there's some eidetickerisms in there, but it should be easy enough to just remove that stuff.

Comment 4

[William Lachance (:wlach)]

Attachment: Test case which still fails for me

Comment 5

[Zac C (:zac)]

William, don't worry about this; my patch is not complete as it's failing in Travis.

I'll switch it back to the old logic but with new waits where I know we need it.

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to William Lachance (:wlach) from comment #3)
> Hmm, the test in bug 917404 is still hanging for me with this change.

I think Will means bug 946298

Comment 8

[Viorela Ioia [:viorela]]

This seems to resolve the intermittent failure in test_everythingme_search_accented. I ran the test with this fix 21 times and got no failures: https://pastebin.mozilla.org/3966606

Comment 9

[Zac C (:zac)]

Comment on attachment 8356733 [details] [review]
github pr

I put this back to the old change_layout if logic which we know works. It's a bit clunky but neatening it was beginning to look very time consuming and risky to the various suites that use gaiatest.

At least now it has solid waits and extra comments to explain the workflows.

Comment 10

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8356733 [details] [review]
github pr

Looks like good strengthening of the keyboard object. I've not run any tests, but the patch looks good to me.

Comment 11

[Viorela Ioia [:viorela]]

It also fixes the intermittent failure in test_everythingme_launch_app: https://pastebin.mozilla.org/3966748

Comment 12

[Trif Andrei-Alin[:AlinT]]

Comment on attachment 8356733 [details] [review]
github pr

r+

Comment 13

[Florin Strugariu [:Bebe]]

merging in

Comment 14

[Florin Strugariu [:Bebe]]

merged in https://github.com/mozilla-b2g/gaia/commit/2f7602c679c1f28e349400e3c00118cdba7796dc