957236 - new mozRTCPeerConnection(); - 100% CPU

Status: VERIFIED FIXED

(Core :: WebRTC, defect)

Description

[Alex]

firefox.exe takes 97% CPU after a mozRTCPeerConnection object creating.
WebRTC don't work.

PS: all add-on are disabled.
WebRTC works fine in the Chrome and Opera browers. (Skype works fine too).

My notebook parameters:
toshiba satellite L40-14b,
RAM: 2GB, CPU: celeron 530 (1.7 GHz),
win7 sp1

Comment 1

[Alex]

the bug in the firefox 27 beta and 29 nightly too.

Comment 2

[Alex]

... and i can't close the firefox (only by the process killing)

For example: 
i can't use the service
https://apprtc.appspot.com/

Comment 3

[Alex]

I found the reason:
http://hg.mozilla.org/releases/mozilla-release/media/mtransport/third_party/nICEr/src/stun/addrs.c
line:
426  c = strchr(munged_ifname, '.');
427  while (c != NULL) {
428    *c = '+';
429     c = strchr(munged_ifname, '+'); // <-- infinit loop!!!
430  }

i.e. If network adapter name has a '.' symbol the WebRTC isn't work!

Comment 4

[Eric Rescorla (:ekr)]

Thanks for the report.

It looks like the fix for this is just to replace the + with a '.' on line 429.

Byron: please confirm. You should also investigate uplifting this to Aurora and Beta.

Comment 5

[Byron Campen [:bwc]]

This analysis looks correct to me, but I don't have a windows VM set up yet. I can go ahead and upload a fix though.

Comment 6

[Byron Campen [:bwc]]

Attachment: Fix infinite loop on win32 when network interfaces contain a '.'

Fix.

Comment 7

[Eric Rescorla (:ekr)]

Comment on attachment 8357838 [details] [diff] [review]
Fix infinite loop on win32 when network interfaces contain a '.'

Review of attachment 8357838 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8357838 [details] [diff] [review]
Fix infinite loop on win32 when network interfaces contain a '.'

https://hg.mozilla.org/integration/mozilla-inbound/rev/65569324e56b

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/65569324e56b

Comment 10

[Byron Campen [:bwc]]

Comment on attachment 8357838 [details] [diff] [review]
Fix infinite loop on win32 when network interfaces contain a '.'

[Approval Request Comment]

Bug caused by (feature/regressing bug #):
   Bug 790517

User impact if declined:

   For some Windows users (those with an interface name containing a '.'), any attempt to use WebRTC will cause an infinite loop in the STS thread, necessitating a force quit of Firefox.

Testing completed (on m-c, etc.):

   The usual suite of tests has run.

Risk to taking this patch (and alternatives if risky):

   Very low.

String or IDL/UUID changes made by this patch:

   None.

Comment 11

[bhavana bajaj [:bajaj]]

(In reply to Alex from comment #0)
> firefox.exe takes 97% CPU after a mozRTCPeerConnection object creating.
> WebRTC don't work.
> 
> PS: all add-on are disabled.
> WebRTC works fine in the Chrome and Opera browers. (Skype works fine too).
> 
> My notebook parameters:
> toshiba satellite L40-14b,
> RAM: 2GB, CPU: celeron 530 (1.7 GHz),
> win7 sp1

Can you please try our next beta once its released on Tuesday and confirm this is fixed for you now? thanks !

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fa25f5461915
https://hg.mozilla.org/releases/mozilla-beta/rev/dde59da464c0

Comment 13

[Ada [:adalucinet]]

Reproduced with 27 beta 2 while making a call between Windows 7 32bit and Windows 7 64bit with a network adapter name containing a '.': the call remains in Connecting state and after I close Firefox, the process remains active with 50% CPU consumption.
 
Verified as fixed on 27 beta 6 (Build ID: 20140113161826), latest Nightly (Build ID: 20140113030203) and latest Aurora (Build ID:20140114004002) with https://apprtc.appspot.com/ and https://apprtc.webrtc.org:

(Caller) Windows 7 32bit - (Callee) Windows 7 64bit
(Caller) Windows 7 64bit - (Callee) Windows 7 32bit