957337 - Mozharness swallows return_code of a talos run if it is 1

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Jordan Lund (:jlund)]

This is my fault. I submitted a talos retry patch last month that I thought would support 0 and 1 return codes from talos while getting mozharness to set an ERROR for anything else.

This was my patch: http://hg.mozilla.org/build/mozharness/rev/1913406e2d96

I should have caught that buildbot_status() will set the return code if we don't explicitly set_return_code=False. I wanted it to set the return code but I didn't want it to overwrite it if it was 1! Patch incoming.

Comment 1

[Jordan Lund (:jlund)]

Attachment: 957337_Mozharness_swallows_return_code_talos_if_1-040114.diff

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 8356818 [details] [diff] [review]
957337_Mozharness_swallows_return_code_talos_if_1-040114.diff

You could also

worst_log_level = ERROR
worst_tbpl_status = TBPL_FAILURE
if self.return_code == 1:
    worst_log_level = WARNING
    worst_tbpl_status = TBPL_WARNING

and then calling the worst_level() for each.  I'm fine with this, though.

Comment 3

[Jordan Lund (:jlund)]

pushed to default with changes as per review: https://hg.mozilla.org/build/mozharness/rev/01bcddcbd6d4

Comment 4

[Armen [:armenzg]]

Merged mozharness (not getting CCed to this bug).

Comment 5

[Jordan Lund (:jlund)]

whoops, this has been resolved