Closed Bug 957337 Opened 9 years ago Closed 8 years ago

Mozharness swallows return_code of a talos run if it is 1

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jlund, Assigned: jlund)

Details

Attachments

(1 file)

This is my fault. I submitted a talos retry patch last month that I thought would support 0 and 1 return codes from talos while getting mozharness to set an ERROR for anything else.

This was my patch: http://hg.mozilla.org/build/mozharness/rev/1913406e2d96

I should have caught that buildbot_status() will set the return code if we don't explicitly set_return_code=False. I wanted it to set the return code but I didn't want it to overwrite it if it was 1! Patch incoming.
Comment on attachment 8356818 [details] [diff] [review]
957337_Mozharness_swallows_return_code_talos_if_1-040114.diff

You could also

worst_log_level = ERROR
worst_tbpl_status = TBPL_FAILURE
if self.return_code == 1:
    worst_log_level = WARNING
    worst_tbpl_status = TBPL_WARNING

and then calling the worst_level() for each.  I'm fine with this, though.
Attachment #8356818 - Flags: review?(aki) → review+
pushed to default with changes as per review: https://hg.mozilla.org/build/mozharness/rev/01bcddcbd6d4
Attachment #8356818 - Flags: checked-in+
Merged mozharness (not getting CCed to this bug).
whoops, this has been resolved
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: General Automation → Mozharness
You need to log in before you can comment on or make changes to this bug.