957360 - Autophone - change phoneid to have hardware as most significant

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, enhancement)

Description

[Bob Clary [:bc] (inactive)]

The phoneid is currently a munged version of the mac address (: replaced by _) followed by the hardware id of the phone from the SUTAgent.ini file.

This results in the hardware being the least signficant portion of the phone id and in phonedash displaying the names of the devices in an order that is unrelated to the hardware. E.g.

00_23_76_96_cc_6f_nexus-one
00_23_76_b1_92_39_nexus-one
04_46_65_fd_2f_e1_samsung-gs2
10_bf_48_cd_c0_0b_nexus-7-jdq39
14_7d_c5_af_c8_e3_samsung-gs2
20_64_32_21_35_70_samsung-gs2
20_64_32_4f_e9_4f_samsung-gs2
38_aa_3c_1c_f6_94_samsung-gs3
38_aa_3c_1e_a8_ee_samsung-gs3
40_fc_89_4c_95_3f_atrix-4g
44_a7_cf_ea_f9_73_lg-revolution
5c_0a_5b_b4_31_32_samsung-gs3
78_d6_f0_cf_8d_11_nexus-s
78_d6_f0_cf_d2_17_nexus-s
80_96_b1_ee_55_e0_atrix
90_21_55_09_87_95_nexus-one
98_0c_82_33_ec_8d_samsung-gs2
98_4b_4a_13_01_84_droid-pro
98_d6_f7_69_34_aa_nexus-4-jdq39
98_d6_f7_69_37_05_nexus-4-jdq39
a8_26_d9_93_fe_4b_htc-sensation
c8_aa_21_ac_0c_b5_droid-pro

If we placed the hardwareID first followed by the serialno of the device we could display the devices grouped by hardwareID. E.g.

atrix-4g_ta20709vkh
atrix_ta300018fe
droid-pro_015f13050c03201f
droid-pro_0a3a8eb60d02201d
htc-sensation_sh1cft502258
lg-revolution_99000044157141
nexus-4-jdq39_0482e519dadfb15b
nexus-4-jdq39_04bf53e1115a0439
nexus-7-jdq39_015d2109f533fa13
nexus-one_ht018p800097
nexus-one_ht09ap802284
nexus-one_ht9cpp809750
nexus-s_32318e41c58f00ec
nexus-s_3833f770946f00ec
samsung-gs2_0009cfb9411b4f
samsung-gs2_304d097f6e5add6f
samsung-gs2_304d19c38653ed7e
samsung-gs2_304d19d2c307be8e
samsung-gs2_304d19fec32a7f9e
samsung-gs3_501a2aa7
samsung-gs3_98095208
samsung-gs3_b313b945

We could also use the ip address instead of the serialno. I have the ip addresses of my phones fixed by my router so the id would not change. E.g.

atrix-4g_192.168.1.39
atrix_192.168.1.16
droid-pro_192.168.1.3
droid-pro_192.168.1.40
htc-sensation_192.168.1.38
lg-revolution_192.168.1.7
nexus-4-jdq39_192.168.1.37
nexus-4-jdq39_192.168.1.45
nexus-7-jdq39_192.168.1.42
nexus-one_192.168.1.27
nexus-one_192.168.1.31
nexus-one_192.168.1.9
nexus-s_192.168.1.11
nexus-s_192.168.1.15
samsung-gs2_192.168.1.30
samsung-gs2_192.168.1.4
samsung-gs2_192.168.1.41
samsung-gs2_192.168.1.5
samsung-gs2_192.168.1.6
samsung-gs3_192.168.1.12
samsung-gs3_192.168.1.14
samsung-gs3_192.168.1.26

I think I prefer the hardware_ipaddress. Thoughts?

Comment 1

[Mark Côté [:mcote]]

Starting with the model makes sense to me.  Although include the IP addresses makes things a bit clearer, I worry about that long-term, e.g. if a phone is moved to another cluster, or you get a new router, or whatever.

Comment 2

[Bob Clary [:bc] (inactive)]

fixed by bug 990601 where we transitioned to using device names.