957378 - Cannot edit content, ckeditor error (TypeError: r is undefined)

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Editing, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

What did you do?
================
I'm trying to edit the WebAPI doc page for Apps.getSelf()

https://developer.mozilla.org/en-US/docs/Web/API/Apps.getSelf

but am unable to when I click on the Edit button.

What happened?
==============
When I click on edit, the editor area is blank, and I see the following error in the JS console:

TypeError: r is undefined,  ckeditor-min.js:3

What should have happened?
==========================
I should be able to edit the page.

Is there anything else we should know?
======================================
When I go to the Preview Changes view, I see this error:

TemplateExecutionError at document offset 3 in macro DomRef ([]) ( edit ): 

Which looks like it has something to do with tag parsing:

Problem executing template DomRef:
    1 | <p>{{ DomRef() }}</p>
-----------^
    2 | <p>{{ non-standard_header() }}</p>
    3 | <h2 id="Summary">Summary</h2>

TypeError: ejs:50
    48| 
    49| %><%- result %></span>
 >> 50| <%
    51| function containsTag(tagList, tag) {
    52|     if (!tagList || typeof tagList == 'undefined') return 0;
    53|     if (!tag || typeof tag == 'undefined') return 0;

Cannot call method 'split' of undefined
    at eval at <anonymous> (/data/www/developer.mozilla.org/kuma/kumascript/node_modules/ejs/lib/ejs.js:203:1)
    at /data/www/developer.mozilla.org/kuma/kumascript/node_modules/ejs/lib/ejs.js:201:15
    at /data/www/developer.mozilla.org/kuma/kumascript/lib/kumascript/templates.js:75:30

Comment 1

[David Walsh :davidwalsh]

We're on this ASAP (now).

Comment 2

[David Walsh :davidwalsh]

PR is in for this, will be merged and pushed in a moment.

Comment 3

[David Walsh :davidwalsh]

Fix pushed now.

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

You guys are fast! Thank you!

btw, I'm still seeing the aforementioned error when I try to preview changes on that page:

> There are scripting messages on this page:
>
>    TemplateExecutionError at document offset 3 in macro DomRef ([]) ( edit ): 

Should I file a separate bug for this? Or perhaps this is just an error with the content of this page?

Comment 5

[David Walsh :davidwalsh]

That's a separate KumaScript bug.  I'll have :sheppy look.

Comment 6

[Eric Shepherd [:sheppy]]

(In reply to Michael Henretty [:mhenretty] from comment #4)
> You guys are fast! Thank you!
> 
> btw, I'm still seeing the aforementioned error when I try to preview changes
> on that page:
> 
> > There are scripting messages on this page:
> >
> >    TemplateExecutionError at document offset 3 in macro DomRef ([]) ( edit ): 

It's a known limitation of the macro system. Certain types of macro cannot be rendered in the previews, including that one. I think but am not sure there's a bug filed for that, so you might as well file one, just in case. :)

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Eric Shepherd [:sheppy] from comment #6)
> It's a known limitation of the macro system. Certain types of macro cannot
> be rendered in the previews, including that one. I think but am not sure
> there's a bug filed for that, so you might as well file one, just in case. :)

Done: bug 957703. Thanks guys!