Closed
Bug 957382
Opened 11 years ago
Closed 11 years ago
Remove locking on buildapi caching backends
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Assigned: dustin)
References
Details
Attachments
(1 file)
|
4.47 KB,
patch
|
catlee
:
review+
|
Details | Diff | Splinter Review |
This works with a single redis instance, but is terribly counter to the simple way memcached works.
Instead, values should simply be calculated and added. If that ends up calculating the value multiple times, that's just overhead.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8356876 -
Flags: review?(catlee)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8356876 [details] [diff] [review]
no-locking.patch
I'm still a bit worried about problems with thundering herd biting us without locking
Attachment #8356876 -
Flags: review?(catlee) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
landed, but with automatic updating on buildapi01 already disabled (so no immediate impact)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•