Closed Bug 957382 Opened 10 years ago Closed 10 years ago

Remove locking on buildapi caching backends

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dustin, Assigned: dustin)

References

Details

Attachments

(1 file)

no-locking.patch
4.47 KB, patch
catlee
: review+
Details | Diff | Splinter Review 
This works with a single redis instance, but is terribly counter to the simple way memcached works.

Instead, values should simply be calculated and added.  If that ends up calculating the value multiple times, that's just overhead.
Blocks: 863268
Attached patch no-locking.patch — — Splinter Review 

        Attachment #8356876 -
        Flags: review?(catlee)

    
    

    
  
Comment on attachment 8356876 [details] [diff] [review]
no-locking.patch

I'm still a bit worried about problems with thundering herd biting us without locking

        Attachment #8356876 -
        Flags: review?(catlee) → review+

    
    

    
  
landed, but with automatic updating on buildapi01 already disabled (so no immediate impact)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Component: General Automation → General

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: