Closed
Bug 957400
Opened 11 years ago
Closed 11 years ago
Favicon cache doesn't keep list of favicons-per-page sorted.
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 29
People
(Reporter: ckitching, Assigned: ckitching)
References
Details
Attachments
(1 file)
|
1.25 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
In FaviconsForURL we store a list of different favicon sizes for each in-memory remote favicon.
To satisfy requests for favicons, the cache performs a binary search over this list to find the smallest cached icon larger than the required size. This requires the list of favicons to be sorted.
The approach addInternal in FaviconsForURL uses to ensure this is flawed.
|
Assignee | |
Comment 1•11 years ago
|
||
An almost completely trivial patch to fix the issue.
Assignee: nobody → chriskitching
Status: NEW → ASSIGNED
Attachment #8356888 -
Flags: review?(rnewman)
|
|
Assignee | |
Updated•11 years ago
|
|
||
Updated•11 years ago
|
Attachment #8356888 -
Flags: review?(rnewman) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•