Stop pretending that Attr.specified is deprecated

RESOLVED FIXED in mozilla31

Status

()

Core
DOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: ayg)

Tracking

({dev-doc-complete})

Trunk
mozilla31
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Blink is considering removing this attribute, it would be nice if we did too:

<https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ai6_ySyVITg>

Bug 661327 added deprecation warnings for this attribute in Firefox 7.

Note that the blink-dev thread mentions some usage of this attribute in the wild.

Comment 1

4 years ago
Blink's implementation now matches Firefox in that we print a deprecation warning. I'd like to remove this. Our use counters indicated it's used on 0.04% of pages. Given that the implementation isn't particularly burdensome I expect this is something that won't get removed until usage organically drops.
(Reporter)

Comment 2

4 years ago
(In reply to comment #1)
> Blink's implementation now matches Firefox in that we print a deprecation
> warning. I'd like to remove this. Our use counters indicated it's used on 0.04%
> of pages. Given that the implementation isn't particularly burdensome I expect
> this is something that won't get removed until usage organically drops.

I would really appreciate if you can let us know when you decide to go ahead from removing this from Blink, so that we can remove it from Gecko at the same time as well.  Thanks!
So do we want to remove this?  Comment #1 indicates there's usage in the wild and that Blink doesn't plan to remove it, IIUC.
Flags: needinfo?(ehsan)
(Reporter)

Comment 4

4 years ago
Ah good point.  I remember there was some chatter about jQuery depending on that actually.  Anne, do you know what the current status is?
Flags: needinfo?(ehsan) → needinfo?(annevk)

Comment 5

4 years ago
We cannot remove it. It seems we could clean http://mxr.mozilla.org/mozilla-central/source/dom/webidl/Attr.webidl up a bit to no longer indicate it as extension. And we can remove the warning from http://mxr.mozilla.org/mozilla-central/source/content/base/src/Attr.cpp and maybe do further clean up there too?
Flags: needinfo?(annevk)

Comment 6

4 years ago
We could also leave the warning, the attribute does always return true and is useless therefore. It's not clear to me whether such information would be perceived as useful or a nuisance.
(Reporter)

Comment 7

4 years ago
I think it's best to remove the deprecation warning if we're not planning to remove the feature, to prevent warning fatigue etc.
(Reporter)

Updated

4 years ago
Keywords: dev-doc-needed
Summary: Consider removing Attr.specified → Stop pretending that Attr.specified is deprecated
Assignee: nobody → ayg
OS: Mac OS X → All
Hardware: x86 → All
(Reporter)

Comment 9

4 years ago
Comment on attachment 8411063 [details] [diff] [review]
patch

Review of attachment 8411063 [details] [diff] [review]:
-----------------------------------------------------------------

Please also remove SpecifiedWarning from dom/locales/en-US/chrome/dom/dom.properties and webapprt/locales/en-US/webapprt/overrides/dom.properties.  r=me with that.
Attachment #8411063 - Flags: review?(ehsan) → review+
https://tbpl.mozilla.org/?tree=Try&rev=ddd980a2afc0
Status: NEW → ASSIGNED
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/fce4b77ed366
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Removed the deprecated flag from https://developer.mozilla.org/en-US/docs/Web/API/Attr
Keywords: dev-doc-complete
You need to log in before you can comment on or make changes to this bug.