957430 - Stop pretending that Attr.specified is deprecated

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

Blink is considering removing this attribute, it would be nice if we did too:

<https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ai6_ySyVITg>

Bug 661327 added deprecation warnings for this attribute in Firefox 7.

Note that the blink-dev thread mentions some usage of this attribute in the wild.

Comment 1

[Dominic Cooney]

Blink's implementation now matches Firefox in that we print a deprecation warning. I'd like to remove this. Our use counters indicated it's used on 0.04% of pages. Given that the implementation isn't particularly burdensome I expect this is something that won't get removed until usage organically drops.

Comment 2

[(no longer active)]

(In reply to comment #1)
> Blink's implementation now matches Firefox in that we print a deprecation
> warning. I'd like to remove this. Our use counters indicated it's used on 0.04%
> of pages. Given that the implementation isn't particularly burdensome I expect
> this is something that won't get removed until usage organically drops.

I would really appreciate if you can let us know when you decide to go ahead from removing this from Blink, so that we can remove it from Gecko at the same time as well.  Thanks!

Comment 3

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

So do we want to remove this?  Comment #1 indicates there's usage in the wild and that Blink doesn't plan to remove it, IIUC.

Comment 4

[(no longer active)]

Ah good point.  I remember there was some chatter about jQuery depending on that actually.  Anne, do you know what the current status is?

Comment 5

[Anne (:annevk)]

We cannot remove it. It seems we could clean http://mxr.mozilla.org/mozilla-central/source/dom/webidl/Attr.webidl up a bit to no longer indicate it as extension. And we can remove the warning from http://mxr.mozilla.org/mozilla-central/source/content/base/src/Attr.cpp and maybe do further clean up there too?

Comment 6

[Anne (:annevk)]

We could also leave the warning, the attribute does always return true and is useless therefore. It's not clear to me whether such information would be perceived as useful or a nuisance.

Comment 7

[(no longer active)]

I think it's best to remove the deprecation warning if we're not planning to remove the feature, to prevent warning fatigue etc.

Comment 8

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: patch

Comment 9

[(no longer active)]

Comment on attachment 8411063 [details] [diff] [review]
patch

Review of attachment 8411063 [details] [diff] [review]:
-----------------------------------------------------------------

Please also remove SpecifiedWarning from dom/locales/en-US/chrome/dom/dom.properties and webapprt/locales/en-US/webapprt/overrides/dom.properties.  r=me with that.

Comment 10

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

https://tbpl.mozilla.org/?tree=Try&rev=ddd980a2afc0

Comment 11

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/fce4b77ed366

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fce4b77ed366

Comment 13

[Kohei Yoshino]

Removed the deprecated flag from https://developer.mozilla.org/en-US/docs/Web/API/Attr