Closed
Bug 957437
Opened 10 years ago
Closed 10 years ago
crash in mozilla::widget::GfxInfo::GLStrings::EnsureInitialized()
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: kbrosnan, Assigned: bjacob)
Details
(Keywords: crash, verifyme, Whiteboard: [native-crash][leave open])
Crash Data
Attachments
(2 files)
2.81 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
3.34 KB,
patch
|
bjacob
:
review+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-ba455d76-fd2c-4ef7-8892-cb7102140106. ============================================================= First appeared 2013-12-22 This has crashed on x86 and ARM Android devices. Various Android versions. Only URL is http://www.deviantart.com/messages/notes/#1_0 at this time. samsung Nexus S 16 (REL) HTC Desire HD 10 (REL) unknown AN10G2 9 (REL) samsung GT-I9000 18 (REL) unknown android 9 (REL) HTC HTC One 18 (REL) HTC HTC Desire HD A9191 10 (REL)
Updated•10 years ago
|
Keywords: regressionwindow-wanted,
steps-wanted
Reporter | ||
Comment 1•10 years ago
|
||
We can't get a regression window till we have steps. The First appeared info might give a close approximation.
Keywords: regressionwindow-wanted
Assignee | ||
Comment 2•10 years ago
|
||
Yeah, don't worry about that. Pretty clear what caused this, and what is going on here. I have a patch coming up.
Updated•10 years ago
|
Updated•10 years ago
|
Assignee: nobody → bjacob
tracking-fennec: ? → 28+
Assignee | ||
Comment 3•10 years ago
|
||
Two things: - Size 1x1 might be what causes issues here; switching to size 16x16 to match what we do in GLContextProvider::CreateOffscreen - Handle gracefully the case where GLContext creation fails and gl is null
Attachment #8357923 -
Flags: review?(jmuizelaar)
Comment 4•10 years ago
|
||
Comment on attachment 8357923 [details] [diff] [review] Fix EnsureInitialized Review of attachment 8357923 [details] [diff] [review]: ----------------------------------------------------------------- ::: widget/android/GfxInfo.cpp @@ +81,5 @@ > + // failed (and bug 957437 shows that that can happen) then it might > + // fail again in the future, and we don't want to keep retrying. > + // So we just carry on with empty strings. > + // In the future we might decide to blacklist everything GL-related > + // (aside from GL layers) in that case. For now, it doesn't matter much. I think we should do this now. If we don't know anything about the system we're on we should blacklist everything we can. It would also be good to add a comment about a future solution of having the compositor update gfxInfo with proper strings once it gets a glcontext.
Attachment #8357923 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8357952 -
Flags: review+
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f138d20db7d3 Let's leave this open until we get a confirmation that this fixes real-world crashiness. There is a lot of finger-crossing involved here.
Whiteboard: [native-crash] → [native-crash][leave open]
Target Milestone: --- → mozilla29
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f138d20db7d3
Comment 8•10 years ago
|
||
Did the landed patch work? Can we mark 29 fixed and get uplift to beta if so?
Flags: needinfo?(bjacob)
Reporter | ||
Comment 9•10 years ago
|
||
From crash stats it looks like it did. There are no crashes in 29a2 were as there were 11 crashes on 28a2.
Comment 11•10 years ago
|
||
Let's get this on Beta then, if it's low risk enough for uplift - Benoit can you nominate?
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(bjacob)
Resolution: --- → FIXED
Assignee | ||
Comment 12•10 years ago
|
||
Comment on attachment 8357952 [details] [diff] [review] patch for landing (r=jrmuizel) [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 937204 User impact if declined: crashes Testing completed (on m-c, etc.): already on aurora for a while Risk to taking this patch (and alternatives if risky): low risk, well tested already String or IDL/UUID changes made by this patch: none
Attachment #8357952 -
Flags: approval-mozilla-beta?
Flags: needinfo?(bjacob)
Comment 13•10 years ago
|
||
Comment on attachment 8357952 [details] [diff] [review] patch for landing (r=jrmuizel) Thanks!
Attachment #8357952 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Assignee | ||
Comment 14•10 years ago
|
||
Should I land myself?
Updated•10 years ago
|
status-b2g-v1.3:
--- → fixed
status-b2g-v1.4:
--- → fixed
Updated•10 years ago
|
status-b2g-v1.3T:
--- → fixed
Comment 17•10 years ago
|
||
Issue is resolved - clearing old keywords - qa-wanted clean-up
Keywords: steps-wanted
You need to log in
before you can comment on or make changes to this bug.
Description
•