957489 - Build bustage in media (after bug 906968) error: ISO C++ forbids comparison between pointer and integer

Status: RESOLVED DUPLICATE of bug 938092

(SeaMonkey :: Build Config, defect)

Description

[Edmund Wong (:ewong)]

c-c-trunk is getting this bustage:

make[4]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mozilla/media/webrtc/signaling/test'
make -C media/mtransport/test libs
make[4]: Entering directory `/builds/slave/c-cen-t-lnx/build/objdir/mozilla/media/mtransport/test'
mkdir -p '.deps/'
buffered_stun_socket_unittest.o
/usr/bin/ccache /tools/gcc-4.5/bin/g++ -o buffered_stun_socket_unittest.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -DHAVE_STRDUP -DNR_SOCKET_IS_VOID_PTR -DSCTP_DEBUG -DINET -DINET6 -D__Userspace_os_Linux=1 -DMOZ_GLUE_IN_PROGRAM -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/test -I. -I. -I/builds/slave/c-cen-t-lnx/build/mozilla/media/webrtc/trunk/testing/gtest/include/ -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/ -I/builds/slave/c-cen-t-lnx/build/mozilla/netwerk/sctp/src/  -I. -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/ -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/ -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/src/crypto -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/src/ice -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/src/net -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/src/stun -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/src/util -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nrappkit/src/share -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nrappkit/src/util/ -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nrappkit/src/util/libekr -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nrappkit/src/log -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nrappkit/src/registry -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nrappkit/src/stats -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nrappkit/src/plugin -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nrappkit/src/event  -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nrappkit/src/port/linux/include -I../../../dist/include  -I/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/include/nss      -I../../../dist/include/testing  -fPIC   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/buffered_stun_socket_unittest.o.pp  -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -fno-tree-vrp -pthread -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -Os -freorder-blocks  -fomit-frame-pointer    /builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/test/buffered_stun_socket_unittest.cpp
ice_unittest.o
/usr/bin/ccache /tools/gcc-4.5/bin/g++ -o ice_unittest.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -DHAVE_STRDUP -DNR_SOCKET_IS_VOID_PTR -DSCTP_DEBUG -DINET -DINET6 -D__Userspace_os_Linux=1 -DMOZ_GLUE_IN_PROGRAM -DNO_NSPR_10_SUPPORT -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/test -I. -I. -I/builds/slave/c-cen-t-lnx/build/mozilla/media/webrtc/trunk/testing/gtest/include/ -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/ -I/builds/slave/c-cen-t-lnx/build/mozilla/netwerk/sctp/src/  -I. -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/ -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/ -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/src/crypto -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/src/ice -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/src/net -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/src/stun -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nICEr/src/util -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nrappkit/src/share -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nrappkit/src/util/ -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nrappkit/src/util/libekr -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nrappkit/src/log -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nrappkit/src/registry -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nrappkit/src/stats -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nrappkit/src/plugin -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nrappkit/src/event  -I/builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/third_party/nrappkit/src/port/linux/include -I../../../dist/include  -I/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/include/nss      -I../../../dist/include/testing  -fPIC   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/ice_unittest.o.pp  -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -fno-tree-vrp -pthread -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -Os -freorder-blocks  -fomit-frame-pointer    /builds/slave/c-cen-t-lnx/build/mozilla/media/mtransport/test/ice_unittest.cpp
nrappkit_unittest.o
../../../../../mozilla/media/mtransport/test/buffered_stun_socket_unittest.cpp: In member function ‘void DummySocket::CheckWriteBuffer(uint8_t*, size_t)’:
../../../../../mozilla/media/mtransport/test/buffered_stun_socket_unittest.cpp:147:177: warning: passing NULL to non-pointer argument 3 of ‘testing::AssertionResult testing::internal::CmpHelperNE(const char*, const char*, const T1&, const T2&) [with T1 = int, T2 = mozilla::DataBuffer*]’
../../../../../mozilla/media/mtransport/test/buffered_stun_socket_unittest.cpp:147:177: warning: passing NULL to non-pointer argument 3 of ‘testing::AssertionResult testing::internal::CmpHelperNE(const char*, const char*, const T1&, const T2&) [with T1 = int, T2 = mozilla::DataBuffer*]’
In file included from ../../../../../mozilla/media/mtransport/test/buffered_stun_socket_unittest.cpp:31:0:
../../../../../mozilla/media/webrtc/trunk/testing/gtest/include/gtest/gtest.h: In function ‘testing::AssertionResult testing::internal::CmpHelperNE(const char*, const char*, const T1&, const T2&) [with T1 = int, T2 = mozilla::DataBuffer*]’:
../../../../../mozilla/media/mtransport/test/buffered_stun_socket_unittest.cpp:147:177:   instantiated from here
../../../../../mozilla/media/webrtc/trunk/testing/gtest/include/gtest/gtest.h:1532:136: error: ISO C++ forbids comparison between pointer and integer
make[4]: *** [buffered_stun_socket_unittest.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mozilla/media/mtransport/test'
make[3]: *** [libs] Error 2
make[3]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mozilla'
make[2]: *** [default] Error 2
make[2]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mozilla'
make[1]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir'
make[1]: *** [default] Error 2
make: *** [build] Error 2
program finished with exit code 2
elapsedTime=2006.400994

would disabling webrtc be a workaround? (No clue at all, so I'm just guessing.)

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Probably a gcc 4.5 issue; perhaps the same as the already reported on (not sure if the patch has landed)

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

See bug 938092 which may be related or the same

Comment 3

[Philip Chee]

> See bug 938092 which may be related or the same
Ewong tells me it's WFM on our side.