957503 - Change "Browser-ID" to "BrowserID" in tokenserver Authorization header?

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Server: Token, defect)

Description

[Ryan Kelly [:rfkelly]]

Trivial API nit: the canonical spelling of the protocol name is "BrowserID" [1], not "Browser-ID" as currently used in the tokenserver Authorization header.

Should we change it while we can in the interests of consistency, or is that just pointless API churn?  Nick and Alexis, thoughts?

[1] https://developer.mozilla.org/en-US/Persona/Glossary

Comment 1

[Nick Alexander :nalexander [he/him]]

(In reply to Ryan Kelly [:rfkelly] from comment #0)
> Trivial API nit: the canonical spelling of the protocol name is "BrowserID"
> [1], not "Browser-ID" as currently used in the tokenserver Authorization
> header.
> 
> Should we change it while we can in the interests of consistency, or is that
> just pointless API churn?  Nick and Alexis, thoughts?

Meh.  There's nothing consistent about BrowserID or Persona anyway.  I know from having reverse engineered the data formats :)

Also, all the code that says BrowserID* will never change to Browser-ID.  If we care, it's trivial to change; but I don't care.

Comment 2

[Ryan Kelly [:rfkelly]]

"meh" it is; closing

Comment 3

[James Bonacci [:jbonacci]]

Got it.

Comment 4

[Ryan Kelly [:rfkelly]]

We're mucking around with this endpoint anyway in Bug 959441, let's clean this up while we're at it.

Comment 5

[Ryan Kelly [:rfkelly]]

This is done, and is what will go into production.  I've patched the current dev server to accept both forms so that client code doesn't have to coordinate the fix with a server rollout.

Comment 6

[James Bonacci [:jbonacci]]

OK. I assume this will automatically propagate into Stage and Production.