957514 - [gonk-kk] FakeSurfaceComposer hit compile error

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Kai-Zhen Li [:seinlin][:kli]]

In gonk-kk build, FakeSurfaceComposer hit a compile error.

Comment 1

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: bug-957514-fix.patch

Hi Michael, Can you help me have a look if this is reasonable?

Comment 2

[Michael Wu [:mwu]]

Hm, don't you need to declare these new functions in FakeSurfaceComposer.h ?

Comment 3

[Michael Wu [:mwu]]

Please assign bugs to yourself when appropriate.

Comment 4

[Kai-Zhen Li [:seinlin][:kli]]

Yes, need to declare these in FakeSurfaceComposer.h. Now, MOZ_OMX_DECODE and MOZ_B2G_CAMERA are disabled, so FakeSurfaceComposer.cpp is not compiled. The error is caused by nsAppShell.cpp. 
Do you think we need to move android::FakeSurfaceComposer::instantiate() into MOZ_OMX_DECODER condition check?

Comment 5

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: bug-957514-fix-2.patch

I'll remove FakeSurfaceComposer.cpp at this moment.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/acdb2a60fdaa

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/acdb2a60fdaa

Comment 8

[sb00349044]

Hi,

We are getting below error due to there is no fake SurfaceFlinger.

Line 649: 09-02 18:50:52.906 I/ServiceManager(  819): Waiting for service SurfaceFlinger...
                Line 797: 09-02 18:50:53.906 I/ServiceManager(  819): Waiting for service SurfaceFlinger...
                Line 829: 09-02 18:50:54.906 I/ServiceManager(  819): Waiting for service SurfaceFlinger...
                Line 859: 09-02 18:50:55.906 I/ServiceManager(  819): Waiting for service SurfaceFlinger...
                Line 889: 09-02 18:50:56.906 I/ServiceManager(  819): Waiting for service SurfaceFlinger...

Can any body suggest?