Closed Bug 95759 Opened 18 years ago Closed 16 years ago

localconfig.js contains strings of equals signs (===)

Categories

(Bugzilla :: Bugzilla-General, defect, P2, minor)

2.13

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: myk, Assigned: goobix)

Details

Attachments

(1 file)

localconfig.js contains strings of equals signs (===), which can be
misinterpreted as indicators of a conflict in the file when using grep to find
files with conflicts in them.  Recommendation: use a different character to
underline section headers.
Severity: enhancement → minor
Priority: -- → P2
Target Milestone: --- → Bugzilla 2.16
Workaround: grep for '<<<' instead of '==='.
Component: Bugzilla → Bugzilla-General
Product: Webtools → Bugzilla
Version: Bugzilla 2.13 → 2.13
We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.
Target Milestone: Bugzilla 2.16 → Bugzilla 2.18
Proposed patch.
I'm kind of ambivalent on this one.  ===== is used for all sorts of things.  I
always use <<<< to look for conflicts.

Although you hit that in BugMail.pm with the Perl format strings for the mail
diffs :)
Comment on attachment 127919 [details] [diff] [review]
Replaces "=" with "-" when used as a marker.

r=kiko, cool
Attachment #127919 - Flags: review+
<-- me (patch writer)
Assignee: justdave → jocuri
Flags: approval?
Status: NEW → ASSIGNED
ok, why not.  It's just comments anyway, it won't hurt anything.
Flags: approval? → approval+
Checking in localconfig.js;
/cvsroot/mozilla/webtools/bugzilla/localconfig.js,v  <--  localconfig.js
new revision: 1.2; previous revision: 1.1
done
Thanks, jp, marking as fixed.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.