957643 - [mozlog] Add warn to log warnings in LoggingMixin

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Currently LogginMixin supports info and error, so this would just add warn.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Add warn to LoggingMixin. v1.0

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8357178 [details] [diff] [review]
Add warn to LoggingMixin. v1.0

Review of attachment 8357178 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

What's the procedure for landing mozbase changes and and bumping versions? Am I right that it's all in mozilla-central now? Is that mirrored automatically or do we need to land in two places?

Comment 4

[William Lachance (:wlach)]

We still land in github for now, and bump versions there. If you want your changes for m-c, you'll need to mirror your changes. But there is no need to do to so as afaik the plan is for ahal to do one last mirror with the final switchover.

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: bump-mozlog.patch

Landed in:
https://github.com/mozilla/mozbase/commit/8e3c36c6f07153c74c4ead88b79e58a2093fdf57

I've never done a version bump for mozbase before. I ran the following and have attached the patch for review.

$ ./versionbump.py --diff bump-mozlog.patch mozlog=1.5 mozrunner=5.29
Pulling from git://github.com/mozilla/mozbase.git master
Running ['git', 'pull', 'git://github.com/mozilla/mozbase.git', 'master'], {'cwd': '/Users/dhunt/workspace/mozbase', 'stderr': None, 'stdout': None}
From git://github.com/mozilla/mozbase
 * branch            master     -> FETCH_HEAD
Already up-to-date.
Bumping mozrunner == 5.28 => 5.29
Bumping mozlog == 1.4 => 1.5
Bumping dependencies ['mozlog >= 1.3'] of mozrunner
- Bumping dependency mozlog >= 1.3 => mozlog >= 1.5
Writing diff to bump-mozlog.patch
Running ['git', 'reset', '--hard', 'HEAD'], {}

Comment 6

[William Lachance (:wlach)]

Comment on attachment 8357670 [details] [diff] [review]
bump-mozlog.patch

I usually don't bother with version bumps for review -- I just do them. :) But this looks fine, and I guess we'll need to get into the habit when m-c becomes the canonical location.

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed in:
https://github.com/mozilla/mozbase/commit/d5f5d1976de3166665f8ff024bf1c72c59441c8e

Released:
https://pypi.python.org/pypi/mozlog/1.5
https://pypi.python.org/pypi/mozrunner/5.29