957714 - [Messages] Interacting with message field prevents recipients field from stealing focus (cursor jump)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Nikolai Khristoforov]

Attachment: Logcat

When the user selects the Message text field, the typing cursor appears in the Message text field for a split-second then returns back to To: text field. The issue only occurs when the To: text field has an incorrect contact in it and the incorrect contact is selected. Having an existing contact or a number does not reproduce the issue.

Repro Steps:
1) Updated Buri to BuildID: 20140106004001
2) Open the Messaging app.
3) Select the New Message icon.
4) Select the To: field and input random letters so it does not have an existing contact.
5) Select the Message text field.
6) Select the contact with the red box around it then select the Message field again.

Actual:
The typing cursor will switch back to the To: field after steps 5 and 6.

Expected:
The typing cursor would remain in the Message text field.

Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140106004001
Gaia: 35a60b82f8cf2d759939a350e2dadbb9d8b2f5dc
Gecko: a43cb4b322d3
Version: 28.0a2
Firmware Version: V1.2_20131115

Repro frequency: 100%
See attached: Logcat and Video

Comment 1

[Nikolai Khristoforov]

URL for youtube video: http://youtu.be/U_RAZh9WKYk

This issue reproduces on 1.2 but does not reproduce on 1.1. On 1.1 the typing cursor stays on the Message text field.

Device: Buri 1.1 COM
BuildID: 20140102041202
Gaia: 6ff3a607f873320d00cb036fa76117f6fadd010f
Gecko: bdac595a4e46
Version: 18.0
RIL Version: 01.01.00.019.281
Firmware Version: V1.2_20131115

Device: Buri 1.2 COM
BuildID: 20140106004001
Gaia: 8441587c3b352e052fee07665c21fd192540f19f
Gecko: d552c08a72d0
Version: 26.0
RIL Version: 01.02.00.019.102
Firmware Version: V1.2_20131115

Comment 2

[Rick Waldron [:rwaldron]]

(In reply to Nikolai Khristoforov from comment #0)
> Created attachment 8357277 [details]
> Logcat
> 
> When the user selects the Message text field, the typing cursor appears in
> the Message text field for a split-second then returns back to To: text
> field. The issue only occurs when the To: text field has an incorrect
> contact in it and the incorrect contact is selected. Having an existing
> contact or a number does not reproduce the issue.
> 
> Repro Steps:
> 1) Updated Buri to BuildID: 20140106004001
> 2) Open the Messaging app.
> 3) Select the New Message icon.
> 4) Select the To: field and input random letters so it does not have an
> existing contact.
> 5) Select the Message text field.
> 6) Select the contact with the red box around it then select the Message
> field again.
> 
> Actual:
> The typing cursor will switch back to the To: field after steps 5 and 6.

IIRC, this is intentional because the contact is invalid. I'll have to go back and review all of the discussion for this feature to confirm.

Comment 3

[Jason Smith [:jsmith]]

Can UX weigh in on what the correct behavior is here with a rationale why?

Comment 4

[Rick Waldron [:rwaldron]]

Another aspect to consider is that the user wouldn't be able to send a message to a single invalid recipient: the send button is disabled until there is a valid recipient, whether that's a known contact or the number of an unknown contact.

Comment 5

[Julien Wajsberg [:julienw]]

I actually think this is an unwanted behavior.

I think the "focus in the To: field" behavior happens because we're "assimilating" the recipient, and probably the invalid case has not the same path than the valid case.

If the user taps the "messages" field, then we should focus it, and not focus back to the recipients panel, even if it's invalid.

I ask 1.3? blocking for regression from 1.1.

Asking needinfo from Ayman directly as well.

Comment 6

[Rick Waldron [:rwaldron]]

I agree that it's strange, and I'm going to take this for now so that I can start poking around the code to see what I can come up with. I'm confident that this is caused by the async nature of recipient validation.

Comment 7

[Julien Wajsberg [:julienw]]

This is probably a regression from bug 920546.

Comment 8

[Rick Waldron [:rwaldron]]

(In reply to Julien Wajsberg [:julienw] from comment #7)
> This is probably a regression from bug 920546.

Not probably, it absolutely is, but I don't yet know how to work around it in a reasonably elegant way.

Comment 9

[ayman maat :maat]

as stated in comment 7 and comment 8 this is a regression so i support moving this to 1.3+ in triage.

I also agree with Julien's comment 5 that the behaviour described in comment 0 is unwanted behaviour. Therefore if the user focuses the 'message field' we should focus on it regardless of the content of the 'to field'

Comment 10

[Joe Cheng [:jcheng] (please needinfo)]

since we need to close 1.3 bugs by the end of Jan, assign to Rick for now. Please feel free to unassign if you are not working on it. thanks

Comment 11

[Rick Waldron [:rwaldron]]

(In reply to Joe Cheng [:jcheng] from comment #10)
> since we need to close 1.3 bugs by the end of Jan, assign to Rick for now.
> Please feel free to unassign if you are not working on it. thanks

I've been actively working on this—it's not a simple issue with a simple fix.

Comment 12

[Joe Cheng [:jcheng] (please needinfo)]

Thanks Rick

since 1.3+ is the highest priority now, set target milestone, please make the change if it doesn't work. thanks

Comment 13

[Julien Wajsberg [:julienw]]

Hey Rick, this should land as soon as possible now. Do you think you'll be able to have a first patch soon? Would you prefer that someone (maybe me :) ) take this over?

Comment 14

[Rick Waldron [:rwaldron]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/15770

I've manually tested as many user typing scenarios I could come up with, but another rigorous look would be ideal.

Comment 15

[Julien Wajsberg [:julienw]]

Comment on attachment 8366691 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15770

r=me with a little nit

Comment 16

[Rick Waldron [:rwaldron]]

Comment on attachment 8366691 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15770

I've addressed the weird behaviour, so I'm effectively turning down the "r+" :)

Comment 17

[Julien Wajsberg [:julienw]]

Comment on attachment 8366691 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15770

r=me

LET'S LAND THIS ;)

Comment 18

[Rick Waldron [:rwaldron]]

https://github.com/mozilla-b2g/gaia/commit/aedd5c9636f305d4433491056a0ca984dfb859b1

Comment 19

[Rick Waldron [:rwaldron]]

v1.3 https://github.com/mozilla-b2g/gaia/commit/9fb8dff0277eb9ffe88f6efeb4426ec21c01395b