957731 - Regression: Wrapper content not running OOP

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Ben Francis [:benfrancis]]

It looks like the new window manager may have regressed making wrapper content (e.me apps and homescreen bookmarks) running in their own process.

STR:
* Connect to device over adb
* Run ps
* Start an e.me app
* Run ps again
Expected:
* New content process
Actual:
* Content appears to be running in parent process

I suspect WrapperFactory just needs to set config.oop to true when creating a wrapper window.

Comment 1

[Jason Smith [:jsmith]]

Do we know what branches are affected by this regression? This sounds bad - it should block.

Comment 2

[Ben Francis [:benfrancis]]

Jason: I'm pretty sure it was introduced in the new window manager in 1.4, but we should probably check for a regression window just in case.

Comment 3

[Jason Smith [:jsmith]]

(In reply to Ben Francis [:benfrancis] from comment #2)
> Jason: I'm pretty sure it was introduced in the new window manager in 1.4,
> but we should probably check for a regression window just in case.

For getting the regression window - is there some STR we can follow to determine that OOP is enabled or not?

Comment 4

[Ben Francis [:benfrancis]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/15121

Attached a fix and a simple unit test.

I couldn't find any unit tests for WrapperFactory so I created a new file. Perhaps there is a better way to test this though.

Comment 5

[Ben Francis [:benfrancis]]

Jason, the STR is in comment 0.

You can run:

 $ adb shell ps | grep plugin

to see a list of content processes before and after launching the wrapper.

Comment 6

[Jason Smith [:jsmith]]

Okay - if there's a patch already in progress, then we probably don't need to worry about getting a regression window here.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8357355 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15121

Thanks Ben!!

Comment 8

[Ben Francis [:benfrancis]]

Merged into master
https://github.com/mozilla-b2g/gaia/commit/1634720a836b6d11ca855ed083797e3d47ffe9b6