957783 - opt-only build warning: "CompositableTransactionParent.cpp:238:25: warning: unused variable 'compositable' [-Wunused-variable]"

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Daniel Holbert [:dholbert]]

Opt-only build warning:
{
../../../gfx/layers/ipc/CompositableTransactionParent.cpp: In member function 'bool mozilla::layers::CompositableParentManager::ReceiveCompositableUpdate(const mozilla::layers::CompositableOperation&, mozilla::layers::EditReplyVector&)':
../../../gfx/layers/ipc/CompositableTransactionParent.cpp:238:25: warning: unused variable 'compositable' [-Wunused-variable]
}

The code:
> 238       CompositableHost* compositable = AsCompositable(op);
> 239       MOZ_ASSERT(compositable);
> 240       RefPtr<TextureHost> texture = TextureHost::AsTextureHost(op.textureParent());

(compositable is never used aside from being asserted about)

It looks like it was originally used, when it was added -- before bug 897452, we had "compositable->GetTextureHost()" on line 240, instead of TextureHost::AsTextureHost(). 

That changed here:
http://hg.mozilla.org/mozilla-central/diff/969cfcbb1c9c/gfx/layers/ipc/CompositableTransactionParent.cpp#l1.89
leaving the variable unused. It probably just wants to be dropped.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix: drop the variable

Comment 2

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e97e5004b17a

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e97e5004b17a