957859 - gfx\layers\Compositor.cpp(116) : warning C4305: 'argument' : truncation from 'double' to 'mozilla::gfx::Float'

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning, found when trying bug 957784:
{
gfx\layers\Compositor.cpp(116) : warning C4305: 'argument' : truncation from 'double' to 'mozilla::gfx::Float'

This is in numeric literals passed into the Color() constructor.

As shown here...
 http://mxr.mozilla.org/mozilla-central/source/gfx/2d/Types.h#143
gfx::Color uses "f" suffixes on numeric literals internally, to force "float" type.

We should just use those in this code, too.

Comment 1

[Daniel Holbert [:dholbert]]

Actually, I'll just make this bug track all the related warnings for this file, since they're all the same category (truncating a numeric literal to from double to float):
{
c:\builds\moz2_slave\try-w32-0000000000000000000000\build\gfx\layers\Compositor.cpp(103) : warning C4305: 'initializing' : truncation from 'double' to 'float'
c:\builds\moz2_slave\try-w32-0000000000000000000000\build\gfx\layers\Compositor.cpp(116) : warning C4305: 'argument' : truncation from 'double' to 'mozilla::gfx::Float'
c:\builds\moz2_slave\try-w32-0000000000000000000000\build\gfx\layers\Compositor.cpp(116) : warning C4305: 'argument' : truncation from 'double' to 'mozilla::gfx::Float'
c:\builds\moz2_slave\try-w32-0000000000000000000000\build\gfx\layers\Compositor.cpp(125) : warning C4305: '*=' : truncation from 'double' to 'mozilla::gfx::Float'
c:\builds\moz2_slave\try-w32-0000000000000000000000\build\gfx\layers\Compositor.cpp(126) : warning C4305: '*=' : truncation from 'double' to 'mozilla::gfx::Float'
c:\builds\moz2_slave\try-w32-0000000000000000000000\build\gfx\layers\Compositor.cpp(127) : warning C4305: '*=' : truncation from 'double' to 'mozilla::gfx::Float'
}

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix v2

Updated fix, now adding an "f" suffix to an arg for a Color in ContainerLayerComposite.cpp, too, to fix:
{
gfx\layers\composite/ContainerLayerComposite.cpp(179) : warning C4305: 'argument' : truncation from 'double' to 'mozilla::gfx::Float'
}

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/198d23cf8b64

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/198d23cf8b64