957892 - Support gonk-kk build in gecko

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Kai-Zhen Li [:seinlin][:kli]]

Support gonk-kk build in gecko.

Comment 1

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: bug-957892.patch

Now only NFC module is enabled for gonk-kk. For BT, Camera and others need to be enabled when related bug got fixed.

Comment 2

[Kai-Zhen Li [:seinlin][:kli]]

try server result: https://tbpl.mozilla.org/?tree=Try&rev=50a271b7974b

Comment 3

[Michael Wu [:mwu]]

Comment on attachment 8357520 [details] [diff] [review]
bug-957892.patch

Review of attachment 8357520 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +246,5 @@
>          MOZ_OMX_DECODER=1
>          AC_SUBST(MOZ_OMX_DECODER)
>          ;;
> +    19)
> +        GONK_INCLUDES="-I$gonkdir/frameworks/native/include -I$gonkdir/frameworks/av/include -I$gonkdir/frameworks/av/include/media -I$gonkdir/frameworks/av/include/camera -I$gonkdir/frameworks/native/include/media/openmax -I$gonkdir/frameworks/av/media/libstagefright/include"

Can you cut this include list down to just -I$gonkdir/frameworks/native/include ? This big global include list was a bit of a hack and we should try to minimize it when updating. I checked locally and it seems to work.

Comment 4

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: bug-9957892-fix.patch

Hi, Michael, I try it does work. New patch is updated.

Comment 5

[Michael Wu [:mwu]]

Comment on attachment 8357616 [details] [diff] [review]
bug-9957892-fix.patch

Let's check this in when everything else is landed.

Comment 7

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/b2g-inbound/rev/1f9a100bf649

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1f9a100bf649