Closed Bug 957927 Opened 10 years ago Closed 10 years ago

Set value of b2g.neterror.url in Gaia build script


(Firefox OS Graveyard :: Gaia, defect)

Not set


(Not tracked)



(Reporter: timdream, Assigned: darkowlzz)



(Whiteboard: [good first bug][mentor=yurenju][mentor-lang=zh])


(1 file, 2 obsolete files)

46 bytes, text/x-github-pull-request
: review+
Details | Review
+++ This bug was initially created as a clone of Bug #882186 +++

Bug 882186 introduced a patch in Gecko where |app://| is hard-coded in the pref |b2g.neterror.url|. Such value should be written by Gaia build script instead, similar to the value of |browser.homescreenURL|.

Fail to do so will confuse people when they change the URL of System app.
Flags: needinfo?(yurenju.mozilla)
Whiteboard: [good first bug][mentor=yurenju][mentor-lang=zh]
Cancel needinfo flag and wait someone to take it...
Flags: needinfo?(yurenju.mozilla)
I would like to take this bug.

After searching a bit, I found that build/preferences.js is where I should add
`prefs.push(['b2g.neterror.url', config.GAIA_DOMAIN + '/net_error.html'])`

But I am not sure where net_error.html actually exists.

Am I on right track?
yes you are right.

but GAIA_DOMAIN usually is || so you have to use origin of system app and concat with net_error.html like:

> app://

and if running gaia on browser (use DEBUG=1 make to get a gaia profile for browser) it should be:


and we already declare |homescreen| for system in preference.js:16-17, so you can reuse this one to compose the url you need.

you also can find me on IRC #gaia channel if you have any question.
Assignee: nobody → indiasuny000
Attached file Link to pull request 15388 (obsolete) —
Attachment #8360846 - Flags: review?(yurenju.mozilla)
Comment on attachment 8360846 [details] [review]
Link to pull request 15388

Hi darkowlzz, there is an error for integration test on travis-ci, could you take a look for it?
Attachment #8360846 - Flags: review?(yurenju.mozilla)
Attached file Link to pull request 15516 (obsolete) —
Sent another PR. The error seems to be a build test error this time.
Now how did I trigger that?
Attachment #8360846 - Attachment is obsolete: true
Flags: needinfo?(yurenju.mozilla)
Attachment #8362439 - Attachment is obsolete: true
Comment on attachment 8362792 [details] [review]
Link to pull request 15542

you can go to that travis-ci page and sign in with github account then you will get a restart button on top-right conern.

and the state is green!
Attachment #8362792 - Flags: review+
Flags: needinfo?(yurenju.mozilla)
merged, thank you Sunny!
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.