Set value of b2g.neterror.url in Gaia build script

RESOLVED FIXED

Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: timdream, Assigned: darkowlzz)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=yurenju][mentor-lang=zh])

Attachments

(1 attachment, 2 obsolete attachments)

46 bytes, text/x-github-pull-request
yurenju
: review+
Details | Review
+++ This bug was initially created as a clone of Bug #882186 +++

Bug 882186 introduced a patch in Gecko where |app://system.gaiamobile.org/net_error.html| is hard-coded in the pref |b2g.neterror.url|. Such value should be written by Gaia build script instead, similar to the value of |browser.homescreenURL|.

Fail to do so will confuse people when they change the URL of System app.
Flags: needinfo?(yurenju.mozilla)
Whiteboard: [good first bug][mentor=yurenju][mentor-lang=zh]
Cancel needinfo flag and wait someone to take it...
Flags: needinfo?(yurenju.mozilla)
I would like to take this bug.

After searching a bit, I found that build/preferences.js is where I should add
`prefs.push(['b2g.neterror.url', config.GAIA_DOMAIN + '/net_error.html'])`

But I am not sure where net_error.html actually exists.

Am I on right track?
yes you are right.

but GAIA_DOMAIN usually is |gaiamobile.org| so you have to use origin of system app and concat with net_error.html like:

> app://system.gaiamobile.org/net_error.html

and if running gaia on browser (use DEBUG=1 make to get a gaia profile for browser) it should be:

> http://system.gaiamobile.org:8080/net_error.html

and we already declare |homescreen| for system in preference.js:16-17, so you can reuse this one to compose the url you need.

you also can find me on IRC #gaia channel if you have any question.
Assignee: nobody → indiasuny000
Posted file Link to pull request 15388 (obsolete) —
Attachment #8360846 - Flags: review?(yurenju.mozilla)
Comment on attachment 8360846 [details] [review]
Link to pull request 15388

Hi darkowlzz, there is an error for integration test on travis-ci, could you take a look for it?
Attachment #8360846 - Flags: review?(yurenju.mozilla)
Posted file Link to pull request 15516 (obsolete) —
Sent another PR. The error seems to be a build test error this time.
Now how did I trigger that?
Attachment #8360846 - Attachment is obsolete: true
Flags: needinfo?(yurenju.mozilla)
Attachment #8362439 - Attachment is obsolete: true
Comment on attachment 8362792 [details] [review]
Link to pull request 15542

you can go to that travis-ci page and sign in with github account then you will get a restart button on top-right conern.

and the state is green! 
https://travis-ci.org/mozilla-b2g/gaia/builds/17320112
Attachment #8362792 - Flags: review+
Flags: needinfo?(yurenju.mozilla)
merged, thank you Sunny!
https://github.com/mozilla-b2g/gaia/commit/67d1095c1d78d565f6bae140d7fc1e7ddc50d42c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.