957929 - WebIDL callbacks should pass undefined, not null as the this value if none is provided

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Because that's how ES functions normally work (modulo the non-strict mode coercion [[Call]] does).

Comment 1

[Boris Zbarsky [:bzbarsky]]

Spec bug at https://www.w3.org/Bugs/Public/show_bug.cgi?id=24248

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Pass undefined, not null, as the this value to callbacks if no other value is provided.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Equivalent bugs on Chrome and Safari, except they weren't following the spec to start with: http://code.google.com/p/chromium/issues/detail?id=332663 and https://bugs.webkit.org/show_bug.cgi?id=126680

Comment 4

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: Pass undefined, not null, as the this value to callbacks if no other value is provided.

Compartment assertion and style fixes.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Nikhil, you managed to conflate the patch in this bug and the one in bug 957926?

Comment 6

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8357618 [details] [diff] [review]
Pass undefined, not null, as the this value to callbacks if no other value is provided.

wrong bug and patch.

Comment 7

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ec95f288a57

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7ec95f288a57