Closed
Bug 957929
Opened 12 years ago
Closed 12 years ago
WebIDL callbacks should pass undefined, not null as the this value if none is provided
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
8.73 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
Because that's how ES functions normally work (modulo the non-strict mode coercion [[Call]] does).
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #8357608 -
Flags: review?(peterv)
Blocks: 945766
|
|
Assignee | |
Comment 3•12 years ago
|
||
Equivalent bugs on Chrome and Safari, except they weren't following the spec to start with: http://code.google.com/p/chromium/issues/detail?id=332663 and https://bugs.webkit.org/show_bug.cgi?id=126680
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [need review]
Compartment assertion and style fixes.
Attachment #8357618 -
Flags: review?(jorendorff)
Assignee: bzbarsky → nsm.nikhil
|
|
Assignee | |
Comment 5•12 years ago
|
||
Nikhil, you managed to conflate the patch in this bug and the one in bug 957926?
Assignee: nsm.nikhil → bzbarsky
Comment on attachment 8357618 [details] [diff] [review]
Pass undefined, not null, as the this value to callbacks if no other value is provided.
wrong bug and patch.
Attachment #8357618 -
Attachment is obsolete: true
Attachment #8357618 -
Flags: review?(jorendorff)
|
||
Updated•12 years ago
|
Attachment #8357608 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 7•12 years ago
|
||
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla29
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•