Closed Bug 957932 Opened 12 years ago Closed 12 years ago

Add coverage checkbox for test-agent web interface

Categories

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TestAgent
Platform:
x86_64
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rickychien, Assigned: rickychien)

References

Details

Attachments

(2 files)

Gaia patch PR
46 bytes, text/x-github-pull-request
yurenju
: review+
Details | Review
Test-agent patch PR
52 bytes, text/x-github-pull-request
yurenju
: review+
Details | Review
Enable coverage only can execute from command line interface is inconvenient for testing specified unit tests. So add a coverage button and let people can execute unit tests they want is a good way.
Assignee: nobody → ricky060709
Attached file Gaia patch PR —
Attachment #8357612 - Flags: review?(yurenju.mozilla)
Attachment #8357613 - Flags: review?(yurenju.mozilla)
Status: NEW → ASSIGNED
Ricky, sorry I have no time to review your pull request on this week, I would try to make it on next week.
Attachment #8357612 - Flags: review?(yurenju.mozilla)
Comment on attachment 8357613 [details] [review] Test-agent patch PR Ricky, You pull request overall looks good, but it would be great if we can have a checkbox to enable testing with coverage. let's discuss it tomorrow face to face!
Attachment #8357613 - Flags: review?(yurenju.mozilla)
Summary: Add coverage execute button for test-agent web interface → Add coverage checkbox for test-agent web interface
See Also: → 950083
Attachment #8357612 - Flags: review?(yurenju.mozilla)
Attachment #8357613 - Flags: review?(yurenju.mozilla)
Comment on attachment 8357613 [details] [review] Test-agent patch PR r=yurenju if nits is addressed and set feedback flag to Julien since this pull request migrate some code from Julien's pull request. Julien, is it good to you?
Attachment #8357613 - Flags: review?(yurenju.mozilla)
Attachment #8357613 - Flags: review+
Attachment #8357613 - Flags: feedback?(felash)
Comment on attachment 8357612 [details] [review] Gaia patch PR Ricky, you forgot to merge the source code.
Attachment #8357612 - Flags: review?(yurenju.mozilla)
Comment on attachment 8357612 [details] [review] Gaia patch PR I have fixed!
Attachment #8357612 - Flags: review?(yurenju.mozilla)
Comment on attachment 8357613 [details] [review] Test-agent patch PR Now that I merged the other PR I think you don't need my feedback anymore. Sorry again for this!
Attachment #8357613 - Flags: feedback?(felash)
Comment on attachment 8357612 [details] [review] Gaia patch PR r=yurenju
Attachment #8357612 - Flags: review?(yurenju.mozilla) → review+
Merged in gaia: https://github.com/mozilla-b2g/gaia/commit/cdcce2eca74a362a6109ed666aae533f3418ae12
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
commit reverted. https://github.com/mozilla-b2g/gaia/commit/287db7addd97b8cf9f53be8789537d7057ebbac5 Ricky, seems you removed notification in travis.yml on last modification, please add it back and land again.
Status: RESOLVED → REOPENED
Flags: needinfo?(ricky060709)
Resolution: FIXED → ---
Comment on attachment 8357612 [details] [review] Gaia patch PR >https://github.com/mozilla-b2g/gaia/pull/15749
Attachment #8357612 - Flags: review+ → review?(yurenju.mozilla)
Sorry for this. I have opened an new PR for gaia again.
Flags: needinfo?(ricky060709)
Merged again. https://github.com/mozilla-b2g/gaia/commit/a8e1f74568d2d3a8cb391f721cf17367a247a7c9
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Attachment #8357612 - Flags: review?(yurenju.mozilla) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: