957966 - Single variant bookmarks are not loaded

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Albert [:albert]]

Browser app receives an array of mcc and mnc instead of just one value, so pair mcc/mnc is not found in init.json

Comment 1

[Marcelino Veiga Tuimil [:sonmarce]]

This is a regression, apparently introduced when DSDS support was added

Comment 2

[Albert [:albert]]

Attachment: Patch

Check if mcc and mnc are single values or arrays to avoid wrong look up.

Comment 3

[Jason Smith [:jsmith]]

Obvious blocker

Comment 4

[Ben Francis [:benfrancis]]

Comment on attachment 8357747 [details]
Patch

This code looks fine but I'm not sure whether the logic is correct when choosing the list of default bookmarks. Please see my comment on GitHub and set the review flag again if you're confident this is what we want.

Thanks

Comment 5

[Albert [:albert]]

Comment on attachment 8357747 [details]
Patch

Minor changes, see comments inline in github.

Comment 6

[Ben Francis [:benfrancis]]

Comment on attachment 8357747 [details]
Patch

r+me, thanks!

Comment 7

[Ben Francis [:benfrancis]]

Merged into master
https://github.com/mozilla-b2g/gaia/commit/2a4d5d81f38dfdb05f4bc655e23169790b3ce74d

Needs uplift to 1.3

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 2a4d5d81f38dfdb05f4bc655e23169790b3ce74d to:
v1.3: 5c22628946691999f66ffa7bd8e58b8e67766c6e

Comment 9

[Jason Smith [:jsmith]]

Verified via a sanity test with a SIM-based customization & default customization.