958010 - Disable resolver on gonk

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Kai-Zhen Li [:seinlin][:kli]]

Resolver on gonk is not necessary now. It also causes gonk-kk build failed.

Comment 1

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: bug-958010-fix.patch

Hi Michael, Can you help me to have a look on this patch. I try on my build and it does work.

Comment 2

[Kai-Zhen Li [:seinlin][:kli]]

Try server result: https://tbpl.mozilla.org/?tree=Try&rev=2b6847630c49

Comment 3

[Michael Wu [:mwu]]

Seems to work on try. Maybe you need to clobber after making the change.

Comment 4

[Michael Wu [:mwu]]

Comment on attachment 8357837 [details] [diff] [review]
bug-958010-fix.patch

Review of attachment 8357837 [details] [diff] [review]:
-----------------------------------------------------------------

::: moz.build
@@ -16,5 @@
>  
>  if not CONFIG['LIBXUL_SDK']:
>      add_tier_dir('base', ['mfbt'])
>  
> -    if CONFIG['MOZ_WIDGET_TOOLKIT'] in ('android', 'gonk'):

This can't be turned off on android - we're still supporting old android versions there, AFAIK.

Comment 5

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: bug-958010-fix-2.patch

Hi Michael, I am not sure if it is reasonable? I try on nexus 5 it does work.

Comment 6

[Kai-Zhen Li [:seinlin][:kli]]

Try server result: https://tbpl.mozilla.org/?tree=Try&rev=7f5b16412ac8

Comment 7

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8358176 [details] [diff] [review]
bug-958010-fix-2.patch

I'll update a new patch later.

Comment 8

[Kai-Zhen Li [:seinlin][:kli]]

Hi Michael, 

I verified on gonk-jb build. After resolver is disabled DNS will not work.

I can ping hinet DNS server, but can't resolve any host.

---
root@mako:/ # ping www.google.com.tw
ping: unknown host www.google.com.tw
root@mako:/ # ping 168.95.1.1
PING 168.95.1.1 (168.95.1.1) 56(84) bytes of data.
64 bytes from 168.95.1.1: icmp_seq=1 ttl=248 time=23.2 ms
64 bytes from 168.95.1.1: icmp_seq=2 ttl=248 time=21.4 ms
---

Comment 9

[Marco Chen [:mchen]]

Attachment: To disable wrap of DNS resolver on Gonk-KK only

Hi Michael,

As we discussed, the resolver can be disabled to wrap on gonk-kk version. After leaving the issue on gonk-jb to another bug if we want to disable on gonk-jb too.

Thanks.

Comment 10

[Marco Chen [:mchen]]

s|After|Then|

Comment 11

[Marco Chen [:mchen]]

Attachment: To disable wrap of DNS resolver on Gonk-KK only - version 2

Hi Mike,

In Gonk-KK version, FxOS can directly to use DNS resolver and no necessary to wrap it for using our internal one and actually this leads to build break.

So this patch will leave FxOS on Gonk-kk version to use resolver from external library.

Comment 12

[Marco Chen [:mchen]]

Attachment: To disable wrap of DNS resolver on Gonk-KK only - version 2

Replace to a correct patch without missing "fi".

Comment 13

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: Disable wrap of DNS resolver on Gonk-KK only

Comment 14

[Andreas Gal :gal]

Looks like fennec will break on 4.4 since it will have this enabled. Probably worth filing a bug for it to fix that.

Comment 15

[Andreas Gal :gal]

mwu can you steal this review?

Comment 16

[Mike Hommey [:glandium]]

Comment on attachment 8359212 [details] [diff] [review]
Disable wrap of DNS resolver on Gonk-KK only

Review of attachment 8359212 [details] [diff] [review]:
-----------------------------------------------------------------

::: moz.build
@@ +17,5 @@
>  if not CONFIG['LIBXUL_SDK']:
>      add_tier_dir('base', ['mfbt'])
>  
>      if CONFIG['MOZ_WIDGET_TOOLKIT'] in ('android', 'gonk'):
> +        if CONFIG['MOZ_WIDGET_TOOLKIT'] != 'gonk' or CONFIG['ANDROID_VERSION'] <= '18':

it would be clearer if it was widget==android or (widget==gonk and version <= 18)

Comment 17

[Andreas Gal :gal]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8af7fbd99315

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8af7fbd99315

Comment 19

[Mike Hommey [:glandium]]

What landed is neither what i reviewed or what i suggested. Which effectively disabled this dns code on android.

Comment 20

[Kai-Zhen Li [:seinlin][:kli]]

(In reply to Mike Hommey [:glandium] from comment #19)
> What landed is neither what i reviewed or what i suggested. Which
> effectively disabled this dns code on android.

Mike, John will include what you suggested in bug 961598.