958041 - [DSDS] When unlock SIM PIN in FTE, due to device hasn't camped on network yet, the next SIM manager page will show "No operator" under the SIM.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Enpei]

When unlock SIM PIN in FTE, due to device hasn't camped on network yet, the next SIM manager page will show "No operator" under the SIM. Suggest to change the wording to something like "Searching..." which will not be so frastrated. 

* Build Number                
Fugu
Gaia      22bc6be5b76cdc6d4e9667ff070979041a20ce2f
Gecko     cd8bc54e911470fa6519d461e5e6b3ddc8f57f5f
BuildID   20140109175226
Version   28.0a2

* Reproduce Steps
1. Insert 2 SIM cards in device and one of it is PIN enabled.
2. Unlock PIN in FTE page. Check next SIM Manager page.

* Expected Result
The carrier information under the SIM just got unlocked should be other than just "No operator". Maybe "Searching" will be better or others that will not mislead user that SIM card is broken or out of range.

* Actual Result
"No operator" under the SIM.

* Occurrence rate
100%

Comment 1

[Enpei]

Hi Carrie,

It would be great if you can comment on this bug for a better choice, thank you.

Comment 2

[Enpei]

Attachment: 2014-01-09-14-51-28.png

Comment 3

[Carrie Wang [New account: [e-mail]]]

Hi Enpei, 

Yes, we've discussed this before. The wording "No operator" is a little bit negative and which is not exactly correct. 
I'd suggest to use "searching" to provide the current status for users. Thanks!

Comment 4

[Eric Chang [:ericcc] [:echang]]

Still on Fugu v1.4                                                                    
Gaia      0996eecb1b34e66dba6ab082a9b4f03e6861c0de    
Gecko     b7d7d9a2d4c5c9c2d620d237685700dd560cafce    
BuildID   20140417041552                              
Version   30.0a2

Comment 5

[Manuel Casas Barrado [:mancas]]

Attachment: Text has been changed

Comment 6

[Fernando Campo (:fcampo)]

Comment on attachment 8478906 [details] [review]
Text has been changed

Code is perfect, but I'd go better for a full change of the string id now that the meaning has totally changed. Also, we might want to keep 'noOperator' for the cases when the SIM card is no longer searching, but just unable to connect (I honestly don't know if this is possible tbh, but I have some SIMs that will never connect to a network for example). Anyways, I'd rather have some feedback from l10n about this change.

Comment 7

[Francesco Lodolo [:flod]]

Comment on attachment 8478906 [details] [review]
Text has been changed

Having a string ID "noOperator2" with no connection to the actual text/usage of the string is kind of confusing. 

Since we're already changing the string ID, it makes sense to pick a good one (I'd go for searchingOperator or similar).

Comment 8

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8478906 [details] [review]
Text has been changed

Please, take a look at the new commit. Thanks

Comment 9

[Francesco Lodolo [:flod]]

Comment on attachment 8478906 [details] [review]
Text has been changed

Thanks, looks definitely better.

Comment 10

[Fernando Campo (:fcampo)]

Comment on attachment 8478906 [details] [review]
Text has been changed

yeah, definitely nicer, thanks!

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/248d88faeaf1398d253d8e32982710fed0b97bd4