Closed
Bug 958101
Opened 11 years ago
Closed 11 years ago
onFindResult should take its parameters as an object
Categories
(Toolkit :: Find Toolbar, defect)
Toolkit
Find Toolbar
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: mbrubeck, Assigned: mbrubeck)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
|
8.55 KB,
patch
|
evilpies
:
review+
|
Details | Diff | Splinter Review |
After bug 916481, onFindResult has grown enough parameters that it would be clearer to pass them as "named" parameters in a JS object.
Note: This patch adds "searchString" as one of the parameters passed to onFindResult. This simplifies the code by harmonizing the callback data and the IPC message data. However, it's not strictly needed and I could move it out of the callback data if you'd prefer.
Attachment #8357815 -
Flags: review?(evilpies)
|
Assignee | |
Comment 1•11 years ago
|
||
Adds a couple of changes I missed in the previous patch.
Attachment #8357815 -
Attachment is obsolete: true
Attachment #8357815 -
Flags: review?(evilpies)
Attachment #8357821 -
Flags: review?(evilpies)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8357821 [details] [diff] [review]
patch v2
Thanks.
Attachment #8357821 -
Flags: review?(evilpies) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla29
|
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•