958122 - Keep menu icons

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Ben Bucksch (:BenB)]

Bug 940997 removed icons from the Firefox menu. Both for Firefox menu items and those by addons. The rationale was visual overload due to the newly added buttons at the top. https://bugzilla.mozilla.org/attachment.cgi?id=8357836

This poses 3 problems:
* Menu icons serve an important UX need: They allow faster recognition and are more fun, esp. for "visual" people types.
* Icons can convey state information like checked/unchecked and similar.
  State icons are 10x faster to understand than text.
  Our extension needs icons for that purpose.
* In the new layout, I (as a user) am very likely to miss the top widgets entirely,
  they look like a header to me, not like separate items.
  When everything has icons, it's more obvious that these are separate items.

I recommend:
* Re-add menu icons
* Visually separate the new top cluster of buttons better from the menu.
  This avoids both the visual overload, and also makes the new buttons more
  easily visible.

Comment 1

[Ben Bucksch (:BenB)]

Relevant patch from bug 940997: https://bug940997.bugzilla.mozilla.org/attachment.cgi?id=8349725

Comment 2

[gal007]

Icons are not loading, and are an important UX need. There was a problem before, I coudn't load icons as explained, but then someone tell me to resolve the URI. So, I copy the way I solved that for anyone who need it (still working in Fennec v29).

icon: resolveGeckoURI("chrome://Mille/content/images/icon.png"), 

function resolveGeckoURI(aURI) {
	Components.utils.import("resource://gre/modules/Services.jsm");
	
	if (aURI.startsWith("chrome://")) 
	{
		let registry = Cc['@mozilla.org/chrome/chrome-registry;1'].getService(Ci["nsIChromeRegistry"]);
		return registry.convertChromeURL(Services.io.newURI(aURI, null, null)).spec;
	} 
	else if (aURI.startsWith("resource://")) {
		let handler = Services.io.getProtocolHandler("resource").QueryInterface(Ci.nsIResProtocolHandler);
		return handler.resolveURI(Services.io.newURI(aURI, null, null));
	}
	return aURI;
}

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.