958158 - IonMonkey: Optimize do {} while(false)

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Hannes Verschore [:h4writer]]

Seems to happen a lot on emscripten compiled code. I particularly see an improvement on asmjs-apps-box2d from 6000 to 4000 when using --no-asmjs. Should normally also increase asmsjs-apps-bullet and asmjs-apps-zlib, but I cannot reproduce that.

The idea is to not create a loop for "do {} while(false)", because we can't loop over it. This is mostly used for the handy "break" that can be used inside the loop.

Comment 1

[Hannes Verschore [:h4writer]]

Attachment: WIP to measure

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/7935cefd1d6f55cb7d53932e10a34f567e53cb53
Bug 958158 - Exploitability matview should not limit itself to topcrashes, but include all crashes

https://github.com/mozilla/socorro/commit/bd0e66e1769a9ee7547c4a0f1e4c420cdaa6f258
Merge pull request #1777 from bsmedberg/exploitability-allsigs

fixes bug 958158 - Exploitability matview should not limit itself to topcrashes, but include all crashes

Comment 3

[Selena Deckelmann :selenamarie :selena]

Sorry - my bad bug hygiene!

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/d736abb18d1249b6b80b2a2e75164633df4471d4
Merge pull request #1779 from selenamarie/bug958158-migration-for-exploitability-matview

Fixes bug 958198 - migration for exploitability matview change to process all signatures

Comment 5

[Hannes Verschore [:h4writer]]

Attachment: bug-do-while-false

Comment 6

[Hannes Verschore [:h4writer]]

Note: I cannot replicate the decrease in time from 6000 to 4000. I now see 5000 to 4500 on asmjs-apps-box2d

Comment 7

[Kannan Vijayan [:djvj]]

Comment on attachment 8366624 [details] [diff] [review]
bug-do-while-false

Review of attachment 8366624 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 8

[Hannes Verschore [:h4writer]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f31b9790f1b

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6f31b9790f1b

Comment 10

[Guilherme Lima]

This patch made Firefox 2% faster on Octane-Mandreel!