Closed Bug 958158 Opened 7 years ago Closed 7 years ago

IonMonkey: Optimize do {} while(false)

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: h4writer, Assigned: h4writer)

Details

Attachments

(2 files)

Seems to happen a lot on emscripten compiled code. I particularly see an improvement on asmjs-apps-box2d from 6000 to 4000 when using --no-asmjs. Should normally also increase asmsjs-apps-bullet and asmjs-apps-zlib, but I cannot reproduce that.

The idea is to not create a loop for "do {} while(false)", because we can't loop over it. This is mostly used for the handy "break" that can be used inside the loop.
Attached patch WIP to measureSplinter Review
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/7935cefd1d6f55cb7d53932e10a34f567e53cb53
Bug 958158 - Exploitability matview should not limit itself to topcrashes, but include all crashes

https://github.com/mozilla/socorro/commit/bd0e66e1769a9ee7547c4a0f1e4c420cdaa6f258
Merge pull request #1777 from bsmedberg/exploitability-allsigs

fixes bug 958158 - Exploitability matview should not limit itself to topcrashes, but include all crashes
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Sorry - my bad bug hygiene!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/d736abb18d1249b6b80b2a2e75164633df4471d4
Merge pull request #1779 from selenamarie/bug958158-migration-for-exploitability-matview

Fixes bug 958198 - migration for exploitability matview change to process all signatures
Assignee: nobody → hv1989
Attachment #8366624 - Flags: review?(kvijayan)
Note: I cannot replicate the decrease in time from 6000 to 4000. I now see 5000 to 4500 on asmjs-apps-box2d
Comment on attachment 8366624 [details] [diff] [review]
bug-do-while-false

Review of attachment 8366624 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #8366624 - Flags: review?(kvijayan) → review+
https://hg.mozilla.org/mozilla-central/rev/6f31b9790f1b
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
This patch made Firefox 2% faster on Octane-Mandreel!
You need to log in before you can comment on or make changes to this bug.