958224 - [B2G][Browser] Deactivating the browser in landscape mode causes the browser screen to cut off

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Salem Elkabule]

Attachment: Browser cut off log cat.txt

Description:
When launching the browser and navigating to a valid website. Rotating the screen to be on landscape mode and deactivating the browser or pressing the home button, but when returning to the browser through the task manger and selecting the browser. The browser application will display cut off

Repro Steps:
1) Updated Buri 1.3 
2) Launch the browser
3) Navigate to Myspace.com or any other website
4) Rotate the screen to be in landscape mode
5) Deactivate the application or press the home button
6) Hold the home button to access the task manger
7) Select the browser 
Actual:
The bottom of the browser application is cut off with a black screen

Expected:
The browser should show in full without any cutting of in the page

Environmental Variables
Device: buri 1.3 Moz Ril 
Build ID: 20140107004001
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/71ad7ff30010
Gaia: ff5f06dd321f7d2bf4a5b311ded2c56e865d4f83
Platform Version: 28.0a2

Repro frequency: 100%
See attached: video clip(http://www.youtube.com/watch?edit=vd&v=IPMrhmKU9_I), logcat

Comment 1

[Salem Elkabule]

This issue is not reproducible on buri 1.2

Environmental Variables:
Device: Buri 1.2 MOZ
BuildID: 20140108004002
Gaia: 539a25e1887b902b8b25038c547048e691bd97f6
Gecko: 0d8b879ffd70
Version: 26.0
Firmware Version: 20131115

Comment 2

[Jason Smith [:jsmith]]

This looks like a bug with orientation management in the system app.

Comment 3

[Roland Kunkel [:RolandK]]

The window occurs between the Buri v1.3 builds from 12/5 and 12/6.

- Last Working -

Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20131205040201
Gaia: 1dd0e5c644b4c677a4e8fa02e50d52136db489d9
Gecko: 725c36b5de1a
Version: 28.0a1
Firmware Version: 20131115

- First Broken -

Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20131206040203
Gaia: 8fca2ca67e8a6022fe6ed8cb576e5d59dfb5237f
Gecko: 1401e4b394ad
Version: 28.0a1
Firmware Version: 20131115

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Triage: window management regression.

Alive, could you take a look?

Comment 5

[[e-mail]]

steal it

Comment 6

[[e-mail]]

can reproduce only on 1.3

Comment 7

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

steal it.

Comment 8

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/15441

Hi Alive,
   The root cause is KM missing to listen |appwillcolse| event in v1.3 by cherry-pick bug 937487.
   
   please help to review this patch, thanks.

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

The original STR doesn't involve keyboard, are you sure this would fix defect of comment 0?

Comment 10

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Comment on attachment 8361478 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/15441

remove review flag.

Comment 11

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/15471

Hi Alive,
   Not sure is this a correct solution.
   Please help to review this patch and give me some feedback.

   Thanks.

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8361779 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/15471

This may or may not fix the issue, because the size when closeWindow may not fit the sizing when openWindow.

Please modify AppWindow.prototype.resize to convey the resize call in openWindow.

See v1.4 for reference.

Come to me if you have problems. Thanks.

Comment 13

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/15515

Hi Alive,
   Please help to review this patch, thanks.

Comment 14

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/17262269

patch landed in v1.3:
https://github.com/mpizza/gaia/commit/73b74cdde2cacd2299e2a5ff624dac2c1520e54f