Closed Bug 958295 Opened 6 years ago Closed 6 years ago

Run hazard analysis js shell from dist/bin

Categories

(Release Engineering :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: glandium, Assigned: glandium)

References

Details

(Whiteboard: [mozharness])

Attachments

(1 file)

Bug 950298 is going to change what the js standalone build objdir look like, which makes the js shell move in a subdirectory. Fortunately, both builds with and without the patch applied have the js shell installed in dist/bin, so using it from there makes everyone happy.
Blocks: 950298
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Comment on attachment 8358028 [details] [diff] [review]
Run hazard analysis js shell from dist/bin

I'm ok with it since sfink is:

[14:30]	<sfink>	glandium: let me look closer, I'm worried that it'll break linux64-sh-haz
[14:30]	<sfink>	and it makes dirs['shell_objdir'] misnamed
[14:31]	<sfink>	oh. 'shell' there is referring to the shell that's running the analysis. So the name is ok.
[14:31]	<glandium>	"For simpler tasks like removing the tools dir, I see about a 50% speedup (10s instead of 20s)" why are we still removing the tools dir, mercurial should be well behaved, these days
[14:32]	<sfink>	glandium: that doesn't seem like it'd work. I build the shell in a JS shell-only objdir, so I wouldn't expect it to have a dist subdir.
[14:32]	<glandium>	sfink: standalone js builds have a dist directory
[14:32]	<sfink>	oh, they do?
[14:33]	<coop>	glandium: there are a bunch of improvements yet to be realized there, for sure
[14:33]	<glandium>	the build system is not very different, you know ;)
[14:33]	<sfink>	you're right
[14:33]	<sfink>	yeah, then I'm fine with that change
Attachment #8358028 - Flags: review?(aki) → review+
https://hg.mozilla.org/build/mozharness/rev/906b3c9cbc7e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.