Closed Bug 958369 Opened 6 years ago Closed 6 years ago

Make GLContext enums typed, and drop ContextFlags

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: bjacob, Assigned: bjacob)

References

Details

(Whiteboard: [qa-])

Attachments

(6 files)

No description provided.
$ hg diff --stat -r drop-mesa-llvmpipe-switch:ContextType
 content/canvas/src/CanvasRenderingContext2D.cpp |   2 +-
 content/canvas/src/WebGL2Context.cpp            |   2 +-
 content/canvas/src/WebGLContext.cpp             |   5 +-
 content/canvas/src/WebGLContextGL.cpp           |   8 +-
 content/canvas/src/WebGLContextValidate.cpp     |   2 +-
 content/canvas/src/WebGLContextVertices.cpp     |   2 +-
 content/canvas/src/WebGLRenderbuffer.cpp        |   2 +-
 dom/plugins/base/nsNPAPIPluginInstance.cpp      |   8 +-
 dom/plugins/base/nsPluginInstanceOwner.cpp      |   6 +-
 gfx/gl/GLContext.cpp                            |  40 +++++-----
 gfx/gl/GLContext.h                              |  77 +++++++++-----------
 gfx/gl/GLContextCGL.h                           |   4 +-
 gfx/gl/GLContextEGL.h                           |   4 +-
 gfx/gl/GLContextFeatures.cpp                    |  26 +++---
 gfx/gl/GLContextGLX.h                           |   4 +-
 gfx/gl/GLContextProviderCGL.mm                  |   5 +-
 gfx/gl/GLContextProviderEGL.cpp                 |   5 +-
 gfx/gl/GLContextProviderGLX.cpp                 |  12 +-
 gfx/gl/GLContextProviderImpl.h                  |   7 +-
 gfx/gl/GLContextProviderWGL.cpp                 |  19 ++---
 gfx/gl/GLContextTypes.h                         |  38 ++++------
 gfx/gl/GLContextWGL.h                           |   4 +-
 gfx/gl/GLReadTexImageHelper.cpp                 |   2 +-
 gfx/gl/GLSharedHandleHelpers.cpp                |  16 ++--
 gfx/gl/GLTextureImage.cpp                       |  10 +-
 gfx/gl/GLUploadHelpers.cpp                      |  12 +-
 gfx/layers/client/ClientCanvasLayer.cpp         |   2 +-
 gfx/layers/opengl/TextureHostOGL.h              |   2 +-
 28 files changed, 151 insertions(+), 175 deletions(-)
Comment on attachment 8358120 [details] [diff] [review]
1/5 - Make GLFeature a typed enum

Review of attachment 8358120 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContext.h
@@ +85,1 @@
>          bind_buffer_offset,

This is over-indented now.
Attachment #8358120 - Flags: review?(jgilbert) → review+
Attachment #8358121 - Flags: review?(jgilbert) → review+
Attachment #8358122 - Flags: review?(jgilbert) → review+
Holding off on reviewing 4 and 5 until we've resolved whether/how to allow LLVMpipe usage.
Attachment #8358125 - Flags: review?(jgilbert) → review+
Attachment #8358127 - Flags: review?(jgilbert) → review+
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.