Make GLContext enums typed, and drop ContextFlags

RESOLVED FIXED in mozilla29

Status

()

Core
Graphics
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

Trunk
mozilla29
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(6 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8358120 [details] [diff] [review]
1/5 - Make GLFeature a typed enum
Attachment #8358120 - Flags: review?(jgilbert)
(Assignee)

Comment 2

4 years ago
Created attachment 8358121 [details] [diff] [review]
2/5 - Make GLVendor and GLRenderer typed enums
Attachment #8358121 - Flags: review?(jgilbert)
(Assignee)

Comment 3

4 years ago
Created attachment 8358122 [details] [diff] [review]
3/5 - Make SharedTextureShareType and SharedTextureBufferType typed enums
Attachment #8358122 - Flags: review?(jgilbert)
(Assignee)

Comment 4

4 years ago
Created attachment 8358125 [details] [diff] [review]
4/5 - remove the ContextFlags enum
Attachment #8358125 - Flags: review?(jgilbert)
(Assignee)

Comment 5

4 years ago
Created attachment 8358127 [details] [diff] [review]
5/5 - Make ContextType a typed enum
Attachment #8358127 - Flags: review?(jgilbert)
(Assignee)

Comment 6

4 years ago
$ hg diff --stat -r drop-mesa-llvmpipe-switch:ContextType
 content/canvas/src/CanvasRenderingContext2D.cpp |   2 +-
 content/canvas/src/WebGL2Context.cpp            |   2 +-
 content/canvas/src/WebGLContext.cpp             |   5 +-
 content/canvas/src/WebGLContextGL.cpp           |   8 +-
 content/canvas/src/WebGLContextValidate.cpp     |   2 +-
 content/canvas/src/WebGLContextVertices.cpp     |   2 +-
 content/canvas/src/WebGLRenderbuffer.cpp        |   2 +-
 dom/plugins/base/nsNPAPIPluginInstance.cpp      |   8 +-
 dom/plugins/base/nsPluginInstanceOwner.cpp      |   6 +-
 gfx/gl/GLContext.cpp                            |  40 +++++-----
 gfx/gl/GLContext.h                              |  77 +++++++++-----------
 gfx/gl/GLContextCGL.h                           |   4 +-
 gfx/gl/GLContextEGL.h                           |   4 +-
 gfx/gl/GLContextFeatures.cpp                    |  26 +++---
 gfx/gl/GLContextGLX.h                           |   4 +-
 gfx/gl/GLContextProviderCGL.mm                  |   5 +-
 gfx/gl/GLContextProviderEGL.cpp                 |   5 +-
 gfx/gl/GLContextProviderGLX.cpp                 |  12 +-
 gfx/gl/GLContextProviderImpl.h                  |   7 +-
 gfx/gl/GLContextProviderWGL.cpp                 |  19 ++---
 gfx/gl/GLContextTypes.h                         |  38 ++++------
 gfx/gl/GLContextWGL.h                           |   4 +-
 gfx/gl/GLReadTexImageHelper.cpp                 |   2 +-
 gfx/gl/GLSharedHandleHelpers.cpp                |  16 ++--
 gfx/gl/GLTextureImage.cpp                       |  10 +-
 gfx/gl/GLUploadHelpers.cpp                      |  12 +-
 gfx/layers/client/ClientCanvasLayer.cpp         |   2 +-
 gfx/layers/opengl/TextureHostOGL.h              |   2 +-
 28 files changed, 151 insertions(+), 175 deletions(-)
(Assignee)

Comment 7

4 years ago
Created attachment 8358130 [details] [diff] [review]
Combined diff
Comment on attachment 8358120 [details] [diff] [review]
1/5 - Make GLFeature a typed enum

Review of attachment 8358120 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContext.h
@@ +85,1 @@
>          bind_buffer_offset,

This is over-indented now.
Attachment #8358120 - Flags: review?(jgilbert) → review+
Attachment #8358121 - Flags: review?(jgilbert) → review+
Attachment #8358122 - Flags: review?(jgilbert) → review+
Holding off on reviewing 4 and 5 until we've resolved whether/how to allow LLVMpipe usage.
Attachment #8358125 - Flags: review?(jgilbert) → review+
Attachment #8358127 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/08f0663b62bb
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cd12a362c61
https://hg.mozilla.org/integration/mozilla-inbound/rev/b930db813245
https://hg.mozilla.org/integration/mozilla-inbound/rev/9797b751a8a3
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2dd397d92c4
Assignee: nobody → bjacob
Target Milestone: --- → mozilla29
https://hg.mozilla.org/mozilla-central/rev/08f0663b62bb
https://hg.mozilla.org/mozilla-central/rev/4cd12a362c61
https://hg.mozilla.org/mozilla-central/rev/b930db813245
https://hg.mozilla.org/mozilla-central/rev/9797b751a8a3
https://hg.mozilla.org/mozilla-central/rev/c2dd397d92c4
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
Whiteboard: [qa-]
Depends on: 1147490
You need to log in before you can comment on or make changes to this bug.