958420 - [Display][gonk-kk] remove obsolete code trying to use PIXEL_FORMAT_A_8 with gralloc

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Solomon Chiu [:schiu]]

Google obsoleted PIXEL_FORMAT_A_8 in Kitkat, it need to be seperated from older version from compiling error

Comment 1

[Solomon Chiu [:schiu]]

Attachment: pix-format-a8.diff

Comment 2

[Michael Wu [:mwu]]

Comment on attachment 8358276 [details] [diff] [review]
pix-format-a8.diff

Deferring to Sotaro - I don't know how much we care about these formats. If we don't care, we could remove it completely.

Comment 3

[Peter Chang[:pchang]]

Comment on attachment 8358276 [details] [diff] [review]
pix-format-a8.diff

Review of attachment 8358276 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/ShadowLayerUtilsGralloc.cpp
@@ +158,3 @@
>    case PIXEL_FORMAT_A_8:
>      return gfxImageFormatA8;
> +#endif

I just checked the history that these code were added during android porting.
And I didn't see b2g use pixel_format_A_8 before. Maybe it is good to remove this.

Comment 4

[Sotaro Ikeda [:sotaro]]

I never saw pixel_format_A_8 is used in Android. It could be removed.

Comment 5

[Sotaro Ikeda [:sotaro]]

Actually, b2g phone's(buri) gralloc hal does not support pixel_format_A_8. During developing Bug 946720, some patch unintentionally tried to create pixel_format_A_8 as gfx mask layer. But gralloc hal failed to create it.

Comment 6

[Solomon Chiu [:schiu]]

Attachment: a8-obsoleted.diff

Removed all case handling of PIXEL_FORMAT_A8 which relative to Kitkat's change.

Comment 8

[Andreas Gal :gal]

Comment on attachment 8359022 [details] [diff] [review]
a8-obsoleted.diff

Looks good. A8 isn't supported by gralloc anyway. Please land it asap.

Comment 9

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/b2g-inbound/rev/e9a7aaad1771

Comment 10

[Carsten Book [:Tomcat]]

Hi mwu, sorry had to backout this change because of merge conflicts from mozilla-central to b2g-inbound in regard of the files changes by this push and in order to make the merge i had to backout this changeset

Comment 11

[Ryan VanderMeulen [:RyanVM]]

This was trivial to rebase, so I went ahead and re-landed it.
https://hg.mozilla.org/integration/b2g-inbound/rev/d0b6a2d398b6

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d0b6a2d398b6

Comment 13

[Marco Chen [:mchen]]

The patch missed to remove one PIXEL_FORMAT_A_8.
https://hg.mozilla.org/mozilla-central/file/d0b6a2d398b6/gfx/layers/opengl/GrallocTextureClient.cpp#l271

Comment 14

[Andreas Gal :gal]

Can you do a follow-up?

Comment 15

[Solomon Chiu [:schiu]]

Attachment: pix-format-a8-GrallocTextureClient.diff

I am very sorry for missing the last case in GrallocTextureClient.cpp, and just uploaded the patch.

Comment 16

[Marco Chen [:mchen]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2bf16576a117

Comment 17

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2bf16576a117