958425 - Stop copying Camera app to System app package

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The secure camera is a piece of code copied from Camera app to System app with Makefile. This patch proposed here launch the camera app directly instead to save some ROM size (read: bug 944457)

We should work on a proper fix in bug 951978 and beyond.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Github: https://github.com/mozilla-b2g/gaia/pull/15190

Please read comment 0.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8358291 [details] [review]
Github: https://github.com/mozilla-b2g/gaia/pull/15190

++++

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8358291 [details] [review]
Github: https://github.com/mozilla-b2g/gaia/pull/15190

cool.

Comment 4

[James Zhang (Spreadtrum)]

It also save runtime memory.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8358291 [details] [review]
Github: https://github.com/mozilla-b2g/gaia/pull/15190

r=yurenju

but there is some problem in unit test of camera app.
https://travis-ci.org/mozilla-b2g/gaia/jobs/16708233

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to James Zhang from comment #4)
> It also save runtime memory.

How would this save runtime memory?

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #6)
> (In reply to James Zhang from comment #4)
> > It also save runtime memory.
> 
> How would this save runtime memory?

My colleague pointed out this could save runtime memory used in decompressing package and loading files in caches, etc.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The patch breaks ALL Gaia UI Tests I believe.

Gonna to try to see if that can be fixed on Monday.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://travis-ci.org/mozilla-b2g/gaia/builds/16713505 It looks like someone re-run my tests and it turned green now.

master: https://github.com/mozilla-b2g/gaia/commit/ee0ed4c0f10f18d13957626371f0bce09e4d6303

Comment 10

[Jesse]

Could you merge it into v1.3?

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Jesse from comment #10)
> Could you merge it into v1.3?

We have engineers dedicated on that, once this bug got 1.3+ flag.

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Steven, could you triage this bug?

Comment 13

[Steven Yang [:styang]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #12)
> Steven, could you triage this bug?

Let's put it into 1.3T.

Comment 14

[Joe Cheng [:jcheng] (please needinfo)]

Hi Ying Xu, heard that you will be doing uplifts to 1.3T branch. After you completed the uplift, can you please set status-b2g-v1.3T to fixed? please let us know if you have problems with it. thanks

Comment 15

[yang.zhao]

(In reply to Joe Cheng [:jcheng] from comment #14)
> Hi Ying Xu, heard that you will be doing uplifts to 1.3T branch. After you
> completed the uplift, can you please set status-b2g-v1.3T to fixed? please
> let us know if you have problems with it. thanks

hi,Joe.
'apps/camera/js/app.js' and 'apps/camera/test/unit/app_test.js' are not in branch v1.3t.Could you please give me another patch?Thank you!

Comment 16

[Joe Cheng [:jcheng] (please needinfo)]

hi Tim, is it something that you assist with? Thanks

Comment 17

[Evelyn Hung]

Attachment: point to https://github.com/mozilla-b2g/gaia/pull/17152

a PR for 1.3t, need Tim's review to make sure it's correct.

Comment 18

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8390413 [details] [review]
point to https://github.com/mozilla-b2g/gaia/pull/17152

It should be correct. Thank you very much!

Comment 19

[Tim Guan-tin Chien [:timdream] (please needinfo)]

1.3t: https://github.com/mozilla-b2g/gaia/commit/6495e20961658f3020c8cf59e77214764eca5e04