Closed Bug 958425 Opened 12 years ago Closed 12 years ago

Stop copying Camera app to System app package

Categories

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Lockscreen
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.3T+, b2g-v1.3T fixed, b2g-v1.4 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g 1.3T+
Tracking Flags:
Tracking Status
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed

People

(Reporter: timdream, Assigned: timdream)

Details

Attachments

(2 files)

Github: https://github.com/mozilla-b2g/gaia/pull/15190
46 bytes, text/x-github-pull-request
alive
: review+
johnhu
: review+
yurenju
: review+
Details | Review
point to https://github.com/mozilla-b2g/gaia/pull/17152
46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review
The secure camera is a piece of code copied from Camera app to System app with Makefile. This patch proposed here launch the camera app directly instead to save some ROM size (read: bug 944457) We should work on a proper fix in bug 951978 and beyond.
Attachment #8358291 - Flags: review?(yurenju.mozilla)
It also save runtime memory.
blocking-b2g: --- → 1.3?
Whiteboard: [tarako]
Comment on attachment 8358291 [details] [review] Github: https://github.com/mozilla-b2g/gaia/pull/15190 r=yurenju but there is some problem in unit test of camera app. https://travis-ci.org/mozilla-b2g/gaia/jobs/16708233
Attachment #8358291 - Flags: review?(yurenju.mozilla) → review+
(In reply to James Zhang from comment #4) > It also save runtime memory. How would this save runtime memory?
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #6) > (In reply to James Zhang from comment #4) > > It also save runtime memory. > > How would this save runtime memory? My colleague pointed out this could save runtime memory used in decompressing package and loading files in caches, etc.
The patch breaks ALL Gaia UI Tests I believe. Gonna to try to see if that can be fixed on Monday.
https://travis-ci.org/mozilla-b2g/gaia/builds/16713505 It looks like someone re-run my tests and it turned green now. master: https://github.com/mozilla-b2g/gaia/commit/ee0ed4c0f10f18d13957626371f0bce09e4d6303
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Could you merge it into v1.3?
Flags: needinfo?(timdream)
(In reply to Jesse from comment #10) > Could you merge it into v1.3? We have engineers dedicated on that, once this bug got 1.3+ flag.
Flags: needinfo?(timdream)
Steven, could you triage this bug?
Flags: needinfo?(styang)
blocking-b2g: 1.3? → 1.3T+
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #12) > Steven, could you triage this bug? Let's put it into 1.3T.
Flags: needinfo?(styang)
Whiteboard: [tarako]
Hi Ying Xu, heard that you will be doing uplifts to 1.3T branch. After you completed the uplift, can you please set status-b2g-v1.3T to fixed? please let us know if you have problems with it. thanks
Flags: needinfo?(ying.xu)
(In reply to Joe Cheng [:jcheng] from comment #14) > Hi Ying Xu, heard that you will be doing uplifts to 1.3T branch. After you > completed the uplift, can you please set status-b2g-v1.3T to fixed? please > let us know if you have problems with it. thanks hi,Joe. 'apps/camera/js/app.js' and 'apps/camera/test/unit/app_test.js' are not in branch v1.3t.Could you please give me another patch?Thank you!
Flags: needinfo?(jcheng)
hi Tim, is it something that you assist with? Thanks
Flags: needinfo?(jcheng) → needinfo?(timdream)
a PR for 1.3t, need Tim's review to make sure it's correct.
Attachment #8390413 - Flags: review?(timdream)
Comment on attachment 8390413 [details] [review] point to https://github.com/mozilla-b2g/gaia/pull/17152 It should be correct. Thank you very much!
Attachment #8390413 - Flags: review?(timdream) → review+
Flags: needinfo?(timdream)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: