958452 - [Flatfish][Build] Create new repository for device/allwinner/flatfish on github

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Danny Liang [:dliang]]

We planed to pull flatfish code base to github, so need to create repository for device/allwinners/flatfish on github. Will update what we want to pull in device/allwinners/flatfish later.

Comment 1

[Danny Liang [:dliang]]

Hi Marco,
Please help to review it, https://github.com/dannyliang/device-flatfish
Thanks,

Comment 2

[Danny Liang [:dliang]]

Correct the name of path, it should be "device/allwinner/flatfish"

Comment 3

[Marco Chen [:mchen]]

After discussing it offline, please remove unnecessary files. Thanks.

Comment 4

[Danny Liang [:dliang]]

Hi Marco,
We have removed the non-necessary files, please help to review it, https://github.com/dannyliang/device-flatfish
Thanks,

Comment 5

[Marco Chen [:mchen]]

I think we should put back the folder called device/allwinner/common so most common part for board level can be moved from device level.

Comment 6

[Danny Liang [:dliang]]

Thanks for advice, we have split the device/allwinner/common and device/allwinner/flatfish.
Please help to review it, https://github.com/dannyliang/device-flatfish

Comment 7

[Marco Chen [:mchen]]

1. Do we need Android.mk?

2. Could we just remove first two lines of full_flatfish.mk?

3. Do we need this line?
https://github.com/dannyliang/device-flatfish/blob/master/full_flatfish.mk#L6

4. Do we need 3g data card modules?
https://github.com/dannyliang/device-flatfish/blob/master/full_flatfish.mk#L65

5. The user build will put gaia into system partition. Do we need to explicitly define it?
https://github.com/dannyliang/device-flatfish/blob/master/full_flatfish.mk#L118

6. Since we didn't provide to build boot.img now, files related to init.rc can be removed.
https://github.com/dannyliang/device-flatfish/blob/master/full_flatfish.mk#L109

Comment 8

[Danny Liang [:dliang]]

(In reply to Marco Chen [:mchen] from comment #7)
> 1. Do we need Android.mk?
> 
> 2. Could we just remove first two lines of full_flatfish.mk?
> 
> 3. Do we need this line?
> https://github.com/dannyliang/device-flatfish/blob/master/full_flatfish.mk#L6
> 
> 4. Do we need 3g data card modules?
> https://github.com/dannyliang/device-flatfish/blob/master/full_flatfish.
> mk#L65
> 
> 5. The user build will put gaia into system partition. Do we need to
> explicitly define it?
> https://github.com/dannyliang/device-flatfish/blob/master/full_flatfish.
> mk#L118
> 
> 6. Since we didn't provide to build boot.img now, files related to init.rc
> can be removed.
> https://github.com/dannyliang/device-flatfish/blob/master/full_flatfish.
> mk#L109

For 1,2,4, and 6, we have removed them and built successfully.
For 3, it's dalvik heap setting for tablet, so we don't think it's good to remove it.
For 5, we use eng build now, it's used for B2G still alive after reset phone.

Comment 9

[Danny Liang [:dliang]]

Hi Marco,
Please help to comment what I replied and I also removed something in root folder, please help to review it.
Thanks,

Comment 10

[Marco Chen [:mchen]]

(In reply to Danny Liang [:dliang] from comment #8)
> (In reply to Marco Chen [:mchen] from comment #7)
> > 3. Do we need this line?
> > https://github.com/dannyliang/device-flatfish/blob/master/full_flatfish.mk#L6
> > 
> > 5. The user build will put gaia into system partition. Do we need to
> > explicitly define it?
> > https://github.com/dannyliang/device-flatfish/blob/master/full_flatfish.
> > mk#L118
> > 
> 
> For 3, it's dalvik heap setting for tablet, so we don't think it's good to
> remove it.

Do we really still to use dalvik VM? 

> For 5, we use eng build now, it's used for B2G still alive after reset phone.

I think we can leave this option to each user or any specific reason of flatfish to set it in default.

Comment 11

[Danny Liang [:dliang]]

(In reply to Marco Chen [:mchen] from comment #10)
> (In reply to Danny Liang [:dliang] from comment #8)
> > (In reply to Marco Chen [:mchen] from comment #7)
> > > 3. Do we need this line?
> > > https://github.com/dannyliang/device-flatfish/blob/master/full_flatfish.mk#L6
> > > 
> > > 5. The user build will put gaia into system partition. Do we need to
> > > explicitly define it?
> > > https://github.com/dannyliang/device-flatfish/blob/master/full_flatfish.
> > > mk#L118
> > > 
> > 
> > For 3, it's dalvik heap setting for tablet, so we don't think it's good to
> > remove it.
> 
> Do we really still to use dalvik VM? 
After check, we don't need this on B2G, so I remove it.

> 
> > For 5, we use eng build now, it's used for B2G still alive after reset phone.
> 
> I think we can leave this option to each user or any specific reason of
> flatfish to set it in default.
For 5, to align the real situation on master, we also remove the config.

We also remove some non-necessary setting/config for flatfish, please help to review it.
https://github.com/dannyliang/device-flatfish

Comment 12

[Marco Chen [:mchen]]

This one is pending on whether we can use "--disable-b2g-ril" directly or wait for ril to support dynamically detection. And now we are checking it on the mail loop.

Comment 13

[Marco Chen [:mchen]]

Thanks for mwu's help to create new repo.
And please fire a pull-request or we can discuss it.