958475 - [mozrunner] Add support for --debugger=lldb

Status: NEW

(Testing :: Mozbase, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Trying to use lldb on OS X 10.9 (Mavericks) breaks mozrunner:

$ mozrunner -b /Applications/Firefox/Nightly.app/ --debugger=lldb
Starting: /Applications/Firefox/Nightly.app/Contents/MacOS/firefox -foreground -profile /var/folders/wd/zmy4z7xn7wd7sjq90z1y52f80000gn/T/tmpecfzfI.mozrunner
error: file specified in --file (-f) option doesn't exist: 'oreground'

Also see bug 943734 for a fix made there.

Comment 1

[Andrei Eftimie]

This also affects 10.8 (Mountain Lion)

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The problem here is that lldb needs the `--` separator between the application binary and the application arguments.

Given that we need lldb support for Marionette, I will try to get this fixed.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 958475 - Improve debugger support for mozrunner API.

Review commit: https://reviewboard.mozilla.org/r/127176/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/127176/

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 958475 - Add lldb support to mozrunner.

Review commit: https://reviewboard.mozilla.org/r/127178/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/127178/

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8855298 [details]
Bug 958475 - Improve debugger support for mozrunner API.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/127176/diff/1-2/

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8855299 [details]
Bug 958475 - Add lldb support to mozrunner.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/127178/diff/1-2/

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Follow-up try build to ensure that PGO builds work fine now with the latest patch revisions:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5313bd82666234628891fc2027b4c7a8a048abc8

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8855298 [details]
Bug 958475 - Improve debugger support for mozrunner API.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/127176/diff/2-3/

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8855299 [details]
Bug 958475 - Add lldb support to mozrunner.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/127178/diff/2-3/

Comment 10

[(not currently active) Ted Mielczarek]

Comment on attachment 8855298 [details]
Bug 958475 - Improve debugger support for mozrunner API.

https://reviewboard.mozilla.org/r/127176/#review130420

::: testing/mozbase/mozrunner/mozrunner/base/runner.py:29
(Diff revision 3)
>      unicode_type = unicode
>  else:
>      unicode_type = str
>  
>  
> +# Map of debugging programs to information about them

So a while ago we had someone refactor this same code out of one of the other test harnesses into a `mozdebug` package:
https://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozdebug/mozdebug/mozdebug.py

...but apparently we never made mozrunner use it!

Can you just wire up mozdebug here instead? That seems like it'd be the best solution. With most of our harnesses using mozrunner nowadays we could probably simplify things even further.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #10)
> Can you just wire up mozdebug here instead? That seems like it'd be the best
> solution. With most of our harnesses using mozrunner nowadays we could
> probably simplify things even further.

I could and it would make sense. But what I have seen is that at least one test harness which makes use of mozrunner is using mozdebug itself and simply passing all the final data to mozrunner. Whereby other test harnesses pass in the argument values as retrieved from argparse, and rely on mozrunner to find out the debugger details and args.

So given your comment you want that the debugger and args detection code always runs in mozrunner? It means I would also have to update at least reftests to handle it that way.

Comment 12

[(not currently active) Ted Mielczarek]

I'm OK with either making mozrunner use mozdebug and fixing everything to match, or just making it easy to use the mozdebug bits via mozrunner, whatever winds up being easier to implement. I'd just rather not have all of mozdebug duplicated in mozrunner.

Comment 13

[Eric Rahm [:erahm]]

Any chance we can revive this? It's blocking bug 1261180 which prevents us from debugging marionette tests.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I don't have the time right now to continue. If someone wants to follow up on my existing patch, feel free to take over.