958547 - [DSDS] Either one or both SIM are PIN locked, RSSI should not be on status bar based on UX spec.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Enpei]

Attachment: 2014-01-10-13-56-00.png

Based on UX spec v0.8, when both SIM are in PIN locked, there is no RSSI indicator on notification bar.

* Build Number  
Fugu              
Gaia      a119a0692c24c5ed7c55bab838bae3ecdb9dbec9
Gecko     15ee4e78431b45922b41dea882464b0ccb6b4fac
BuildID   20140110174141
Version   28.0a2

* Reproduce Steps
1. Enable both SIM PIN and make it lock like reset device.
2. After entering OS, skip entering PIN code for both SIM cards.
3. Check RSSI on notification bar.

* Expected Result
Based on UX spec, page 5, there should be no RSSI on notification bar.

* Actual Result
There are SIM1 and SIM2 RSSI with no signal bar.

* Occurrence rate
100%

Comment 1

[Enpei]

Attachment: [SPEC] DSDS v0.8 .pdf

Comment 2

[Gregor Wagner [:gwagner]]

Joe, can you triage this?

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

Yes

how about on Single SIM device? how does it behave? can you help to confirm? Thanks

Comment 4

[Enpei]

(In reply to Joe Cheng [:jcheng] from comment #3)
> Yes
> 
> how about on Single SIM device? how does it behave? can you help to confirm?
> Thanks

For single SIM the icon is grey signal bar. If this is what should be kept, we need to confirm with UX to see if they want to change this on DSDS or not.

Comment 5

[Preeti Raghunath(:Preeti)]

UX,

Please weigh in here.

Comment 6

[Stephany Wilkes]

Flagging Carrie, spec owner and in-house expert for DSDS.

Comment 7

[Carrie Wang [New account: [e-mail]]]

We think if the PIN is locked, the RSSI indicator shouldn't show up. Although there is no signal bar presented, it still looks like the SIM is working with weak signal. Hence, no matter it's single SIM or DSDS, the RSSI shouldn't appear. Thanks!

Comment 8

[Enpei]

Update summary and and expected results:

* Expected Result
Based on UX spec, page 5, there should be no RSSI on notification bar if the SIM is locked.

* Actual Result
No matter one SIM or both are PIN locked, RSSI is still seen on notification bar.

Comment 9

[Jason Smith [:jsmith]]

Joe - Can you finish off triaging this bug?

Comment 10

[Preeti Raghunath(:Preeti)]

David,

Please check

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

I'll check this issue.

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/15763

Alive, could you help review the patch? Thanks!

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks!

master: 5f9da9170e2d6b3923bc4c1b1fcaa4fd8b553cff

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 5f9da9170e2d6b3923bc4c1b1fcaa4fd8b553cff to:
v1.3: 5d789b1fe6ad9953cb9f2ef9c32c5a2b30e705e6

Comment 15

[Enpei]

Verified.
Fugu - 
Gaia      bb36b4164d3e51ca04b612e507e1178f80bf240d
Gecko     4227240a4d3e1e418ced160c2a48cb454d7b5645
BuildID   20140204104742
Version   28.0

Comment 16

[Julien Wajsberg [:julienw] (PTO -> may 13)]

(In reply to Carrie Wang [:carrie] from comment #7)
> We think if the PIN is locked, the RSSI indicator shouldn't show up.
> Although there is no signal bar presented, it still looks like the SIM is
> working with weak signal. Hence, no matter it's single SIM or DSDS, the RSSI
> shouldn't appear. Thanks!

Actually, I would have used the icon with the red cross for this case... When I use the phone it feels strange to not have any icon until we enter the pin. That's not really important though.

Comment 17

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Julien Wajsberg [:julienw] from comment #16)
> Actually, I would have used the icon with the red cross for this case...
> When I use the phone it feels strange to not have any icon until we enter
> the pin. That's not really important though.

Vote for Julien ! Help to ni? Carrie to discuss here for this UX change !

Comment 18

[Carrie Wang [New account: [e-mail]]]

Yes, agree. I'll discuss with VxD to figure out what we can do on icon design. Thanks!