958585 - Packaged apps do not work with symlinks

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Kevin Grandon :kgrandon]

I have a web application which I publish to many different web devices. Because of this I symlink my content folder, then have a launch_path which points inside of that folder. Unfortunately it seems that symlinks are not supported with the simulator.

Comment 1

[Paul Rouget [:paul]]

(In reply to Kevin Grandon :kgrandon from comment #0)
> I have a web application which I publish to many different web devices.
> Because of this I symlink my content folder, then have a launch_path which
> points inside of that folder. Unfortunately it seems that symlinks are not
> supported with the simulator.

It works with a device but not with the simulator?

Comment 2

[Kevin Grandon :kgrandon]

(In reply to Paul Rouget [:paul] from comment #1)
> It works with a device but not with the simulator?

Symlinks do work with the gaia Makefile. I have not tried creating a symlink through adb, though I imagine it would/should work?

Comment 3

[jweathersby]

Paul

I assume we have the same issue when linking js files using the script tag in a packaged app.  If the link points to a symlink the jsfile will not load when debugging in the simulator.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

We noticed over IRC that we currently ignore symlinks when zipping them up for installation.

If we update the app-actor-front[1] to handle symlinks by copying, I think it should resolve this.

[1]: https://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/apps/app-actor-front.js#20

Comment 5

[Lancelot Nyachoto]

Hi 

I would like to work on this bug with some guidance.

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Lancelot, that sounds great!  I've assigned the bug to you.

Check out our hacking guide[1] to get started with our code base.

Also, take a look at the Mercurial FAQ[2] for tips on formatting patches, etc.

For this bug, you'll want to test a packaged app in the App Manager where your local directory contains a symlink to some files somewhere else.  Currently, the symlink is ignored when we install the app, so the app does not work correctly.

Most likely this can be fixed by updating the code I linked to in comment 4.

[1]: https://wiki.mozilla.org/DevTools/Hacking
[2]: https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 7

[Lancelot Nyachoto]

Thanks Ryan, I will checkout the code on comment 4 and revert if I have any questions.

Comment 8

[Lancelot Nyachoto]

Rynan. I'm failing to open the add attachment page. Been trying since yesterday. Is this a permission issue, as I can open the attach page for bug 970047

Comment 9

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Hmm, I have never heard of such an issue before...  Do you get some kind of error message?

Comment 10

[Lancelot Nyachoto]

No errors, is appears to be connecting perpetually. Can I paste the patch as a comment?

Comment 11

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Hmm, we really need to have it as an attachment.  I'd suggest talking to someone in the #bmo IRC room about this issue.

Comment 12

[Lancelot Nyachoto]

Attachment: Updated the app-actor-front to handle symlinks by copying

Comment 13

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8393995 [details] [diff] [review]
Updated the app-actor-front to handle symlinks by copying

Review of attachment 8393995 [details] [diff] [review]:
-----------------------------------------------------------------

Have you tried this out on your own app that uses symlinks?

Comment 14

[Lancelot Nyachoto]

Yes, I symlinked a folder with images. Before I made the change the images will not appear in the app and after that change they were displayed properly.

Comment 15

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8393995 [details] [diff] [review]
Updated the app-actor-front to handle symlinks by copying

Review of attachment 8393995 [details] [diff] [review]:
-----------------------------------------------------------------

Huh, so it does!  Sorry for doubting, I just expected more changes to be needed! :)

Update your patch, and then I'll submit it to try to be sure we aren't breaking any tests.

::: toolkit/devtools/apps/app-actor-front.js
@@ +23,5 @@
>    while (files.hasMoreElements()) {
>      let file = files.getNext().QueryInterface(Ci.nsIFile);
>  
>      if (file.isHidden() ||
> +        //file.isSymlink() ||   /*Bug 958585  Add support for symlinks  

Actually remove this line...

Comment 16

[Lancelot Nyachoto]

Attachment: Updated the app-actor-front to handle symlinks by copying

Comment 17

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8395192 [details] [diff] [review]
Updated the app-actor-front to handle symlinks by copying

Great, thanks!  

I've submitted a try run: https://tbpl.mozilla.org/?tree=Try&rev=f81f743f333a

If it goes well, we can check this in.

Comment 18

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Looks okay to me, we'll have a sheriff land it for us.  Thanks again!

Comment 19

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/50ada08f07ee

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/50ada08f07ee