958666 - Autofocus is delayed until first user interaction on fxos

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Ross Kuhlman ([e-mail])]

Attachment: WikipediaLog.txt

Mobile sites that feature radio buttons or search bars can perform strangely. The bar or button will get selected even if the user has not tapped in the hitbox to select them. When this happens, the page will auto scroll to place the button or bar into the viewing area. In some situations, the page will repeatedly scroll to the radio button, making it effectively impossible to view the rest of the page. This issue has been observed repeatedly with the search bar on the front page of wikipedia.org, and occasionally on amazon pages that contain radio buttons.

Repro Steps:
1) Updated Buri to BuildID: 20140106004001
2) Launch Browser app.
3) Navigate to www.wikipedia.org.
4) Attempt to scroll to the bottom of the page.

Actual:
Cursor is placed in the search bar, the keyboard appears onscreen, and Browser auto-scrolls to the very top of the page.

Expected:
Search bar is not highlighted unless user taps directly on search bar. Browser does not repeatedly auto-scroll user.

Environmental Variables:
Device: Buri v1.3 Moz RIL
BuildID: 20140106004001
Gaia: 35a60b82f8cf2d759939a350e2dadbb9d8b2f5dc
Gecko: a43cb4b322d3
Version: 28.0a2
RIL Version: 01.02.00.019.102
Firmware Version: Settings > Device Information > More Information > Firmware revision (example.D30008m)

Notes:

Repro frequency: 100% on wikipedia.org, ~70% on amazon.com
See attached: logcats.

Comment 1

[Ross Kuhlman ([e-mail])]

Attachment: AmazonLog.txt

I have also attached a logcat of radio buttons acting strangely at amazon.com

Comment 2

[Jason Smith [:jsmith]]

Does this reproduce on 1.1 or 1.2?

Comment 3

[pfield]

This issue appears to occur in Buri 1.2 COM RIL.

Environmental Variables
Device: Buri v 1.2.0 COM RIL
Build ID: 20140121004053
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/c9f305c1d9a7
Gaia: 539a25e1887b902b8b25038c547048e691bd97f6
Platform Version: 26.0
RIL Version: 01.02.00.019.102 
Firmware Version: V1.2-device.cfg

Comment 4

[pfield]

Does not appear to occur in Buri 1.1 COM RIL.

Environmental Variables
Device: Buri v 1.1.0 COM RIL
Build ID: 20140121041200
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/e7a8e7b9b7d2
Gaia: 6ff3a607f873320d00cb036fa76117f6fadd010f
Platform Version: 18.1
RIL Version: 01.01.00.019.281 
Firmware Version: V1.2-device.cfg

Comment 5

[Jason Smith [:jsmith]]

Strange regression, but I can reproduce it & it's annoying. This forces interaction with a HTML input element that a user hasn't requested to interact with, which heavily slows down the user from what he/she is intending to do.

Comment 6

[Preeti Raghunath(:Preeti)]

Gregor,

Please reassign

Comment 7

[Gregor Wagner [:gwagner]]

Can we get a regression range?

Comment 8

[Sarah Parsons]

This issue reproduces all the way back to the first Buri 1.2 Build ID: 20130621031231

Gaia   e2f19420fa6a26c4287588701efaec09a750dba1
SourceStamp 7ba8c86f1a56
BuildID 20130621031231
Version 24.0a1

Comment 9

[Gregor Wagner [:gwagner]]

So this is not a regression?

Comment 10

[Jason Smith [:jsmith]]

(In reply to Gregor Wagner [:gwagner] from comment #9)
> So this is not a regression?

It's still a regression. The above regression range implies this regressed during the timeframe when we didn't have 1.2 builds. However, this doesn't reproduce on 1.1.

Comment 11

[Gregor Wagner [:gwagner]]

Dale, can you take a look please?

Comment 12

[Dale Harvey (:daleharvey)]

Yup doing that now

Comment 13

[Dale Harvey (:daleharvey)]

So at least in the case of wikipedia, this is because we for some reason only autofocus when the user starts interacting with the page, this means a user scrolls down then suddenly the autofocus grabs the page and scroll gets triggered)

There are a few bugs relating to autofocus being problematic on mobile, given the lack of screen space it seems like we should just disable it. 

I feel like the current behaviour might be an intentional workaround for not hiding the page on first load as it behaves consistently and would seem hard to do by accident

Comment 14

[Dale Harvey (:daleharvey)]

I cant find anything in the log to suggest this is on purpose, taking a look at gecko to see what could be causing it, may be tricky though |prefs.push(['browser.autofocus', false])| fixes it though, I think it should be given serious thought, any site that autofocus's on load is essentially invisible on fxos, it seems like the semantics are very different on mobile (where its easy to tap the input)

Will take a look at the radio buttons thing to see if thats a seperate bug

Comment 15

[Dale Harvey (:daleharvey)]

There isnt a radio button on amazon.com

Comment 16

[Dale Harvey (:daleharvey)]

The same delayed autofocus behaviour applies to radio buttons though, so will assume that was the reported problem

Comment 17

[Dale Harvey (:daleharvey)]

Attachment: Disable autofocus on b2g

This disables autofocus on b2g, the majority of the large sites will disable the autofocus themselves when they service mobile content, it still happens on sites, primarily responsive / desktop ones

Comment 18

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8367579 [details] [review]
Disable autofocus on b2g

Please add the pref to b2g/app/b2g.js with a bug number to turn it back on with the right behavior (followup bug that needs to be filed).

Comment 19

[Dale Harvey (:daleharvey)]

Attachment: 958666.patch

Comment 20

[Dale Harvey (:daleharvey)]

https://hg.mozilla.org/integration/b2g-inbound/rev/93d6dfcc20e7

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Backed out for reftest failures.
https://hg.mozilla.org/integration/b2g-inbound/rev/6b9778c7b36f

https://tbpl.mozilla.org/php/getParsedLog.php?id=33816113&tree=B2g-Inbound

Comment 22

[Dale Harvey (:daleharvey)]

Attachment: 958666.patch

Ugh sorry, disabling the autofocus test on B2G, carrying r+, pushing to try to make sure 

https://tbpl.mozilla.org/?tree=Try&rev=3f4c5278d9d3

Comment 23

[Dale Harvey (:daleharvey)]

Attachment: 958666.patch

Fixed reftest mistake, carrying r+, got a green try push https://tbpl.mozilla.org/?tree=Try&rev=869e743bb02d

https://hg.mozilla.org/integration/b2g-inbound/rev/e76b333631e0

Comment 24

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e76b333631e0

Comment 25

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e19f79f6a19f