958686 - Open in new tab context menu available in NetMonitor, even when the table is empty

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Tim Nguyen :ntim]

When you right click the network monitor when there are no requests, it shows a context menu with "open in new tab". This is useless and confusing.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

RequestsMenuView.prototype._onContextShowing() only filters out the "Resend" and "Copy URL" items. It should do the same with "Open in a new Tab".

Comment 2

[Victor Porof [:vporof][:vp]]

Thanks for mentoring this Past! :)

Comment 3

[Sterling Graham]

Hi there, I'd like to be assigned this as a first bug. So far I have compiled a debug build, and am having a look inside the RequestsMenuView.prototype._onContextShowing() function. 

As I understand it what I should do is find the ID for the "Open in a New Tab" menu item, then hide it if this.selected item is null in the same way the "Copy URL" menu item is done.

Comment 4

[Sterling Graham]

Attachment: bug-958686-fix.patch

Patch implementing what I described in my previous comment.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8359581 [details] [diff] [review]
bug-958686-fix.patch

Review of attachment 8359581 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good and works as expected. Thanks for the patch!

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Changed the commit message to better describe what the change was and landed in fx-team:

https://hg.mozilla.org/integration/fx-team/rev/eff6ff4dd6d2

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eff6ff4dd6d2

Comment 8

[Tim Nguyen :ntim]

Removing the good first bug tags as this bug is fixed.

Comment 9

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The good first bug tags can remain.  Bugs are filtered out of the dashboard by status.  The tags are used after bug closing to update Mentor Watch[1].

[1]: http://www.joshmatthews.net/mentorwatch/