958712 - HTTP/2 push continuations not completely implemented

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[u408661]

See bug 950768 comment 25 for the details. Basically, we're missing some queuing logic for push continuations like we have for pull header continuations. We should fix that, and remove the check about kFlag_END_PUSH_PROMISE from around line 1340 of Http2Session.cpp so that we fully support push header continuations.

Comment 1

[u408661]

Attachment: part 1 - update node-http2 on CI for bugfix

Comment 2

[u408661]

Attachment: part 2 - fix our push continuation implementation

Comment 3

[u408661]

Attachment: part 3 - tests for continuations

Comment 4

[u408661]

mozreview doesn't like my multi-bug series of patches, so it's back to splinter for this one. These patches (specifically the one that adds tests) depend on the patches in bug 1127568

Comment 5

[u408661]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b4e04f0c275

Comment 6

[u408661]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/a93ad0ca3442
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/6a529065cc9e
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/26ad04ac4ba3

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a93ad0ca3442
https://hg.mozilla.org/mozilla-central/rev/6a529065cc9e
https://hg.mozilla.org/mozilla-central/rev/26ad04ac4ba3