95873 - Crash deleting certs under "Your Certificates" (cert manager)

Status: VERIFIED DUPLICATE of bug 97664

(Core :: Layout, defect, P1)

Description

[ckritzer (gone)]

1) Open Certificate Manager (Edit:Prefs:Privacy and
Security:Certificates:[Manage Certificate...]
2) Select a cert under "Your Certificates" and click the [Delete] button.
3) Click the [OK] button on the "Delete your Certificates" dialogue

For Win98SE, effectively clicking [OK] is the same as clicking [Cancel]. 
Unfortunately, on LinRH62, MacOS_X & MacOS91, the app crashes.

Marking NS Confidential.  If I'm wrong, please change it.

Comment 1

[ckritzer (gone)]

This bug blocks 87361 - I need to delete my certificates in my cert database so
I can test just the iButton.

Comment 2

[Stephane Saux]

->ddrinan for triage.
Chris, Regarding this bug blocking 87361, can't you use a fresh profile?

Comment 3

[David P. Drinan]

-> rangansen

Comment 4

[David P. Drinan]

Adding [e-mail] to the cc-list to see if he can shed some light on 
this crash.

Here is a stack trace of the crash. It's not in PSM code but in 
mozilla/view/src/nsViewManager.

nsViewManager::ProcessPendingUpdates(nsIView * 0x00000000) line 1635 + 7 bytes
nsViewManager::FlushPendingInvalidates(nsViewManager * const 0x067b5d00) line 
3827
nsViewManager::ProcessInvalidateEvent() line 3835
nsInvalidateEvent::HandleEvent() line 141
HandlePLEvent(nsInvalidateEvent * 0x06804b70) line 155
PL_HandleEvent(PLEvent * 0x06804b70) line 590 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x066ae290) line 520 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x00cd06ec, unsigned int 49446, unsigned int 0, 
long 107668112) line 1071 + 9 bytes
USER32! 77e71820()
066ae290()

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It looks like mRootView is null, probably because the view was destroyed before
the invalidate was processed. But in that case we should have revoked the
outstanding InvalidateEvent. So, no obvious culprit.

Comment 6

[Stephane Saux]

marking nsenterprise, crash.
This must be fixed for 0.9.4
Robert, should I reassign this bug to the layout component?

Comment 7

[Rangan Sen]

Including Kevin McCluskey in the cc list - Kevin is the owner of the Clipping
and Compositing module  [as per mozilla listing] which includes the
nsViewManager.cpp file; and he might be able to throw some light on what can be
done about this...

Comment 8

[Rangan Sen]

Reassigning this bug to the Clipping and Compositing - that is where this crash
is happening. It happens because of nsViewManager::ProcessPendingUpdates getting
a null nsView handle, and does not seem to be triggered in the PSM code.
Copying Stephane as well, for his comments 

Comment 9

[Rangan Sen]

Reassigning to browser->layout - that seems to be the nearest match

Comment 10

[grega]

adding nsenterprise+

Comment 11

[Rangan Sen]

adding myself to the cc list

Comment 12

[karnaze (gone)]

Reassigning to kmcclusk.

Comment 13

[Stephane Saux]

*** Bug 98282 has been marked as a duplicate of this bug. ***

Comment 14

[Stephane Saux]

Nominating nsbranch.
Additional talkbacks:
http://cyclone/reports/SingleIncidentInfo.cfm?dynamicBBID=35218241
http://cyclone/reports/SingleIncidentInfo.cfm?dynamicBBID=35218184

Comment 15

[Kevin McCluskey (gone)]

Marking nsbranch+

Comment 16

[Stephane Saux]

cc'ing Terry Hayes

Comment 17

[Stephane Saux]

Kevin:
Here's a reproducible test case:
Create a new profile.
start on new profile.
pref->priv & sec->Master Passwords->change password (enter a non-empty pwd)
pref->priv & sec->certificates->manage certs->restore (restore a cert from a p12)

At this point you have a cert in your cert db, and your cert db has a pwd.

Exit.
Start on same profile.
Tasks->Priv & sec->Pwd manager->logout (you get some dialog)
Prefs->priv & sec->certificates->manage certs. Select a cert and delete, click
ok on resulting dialog and crash.

Look me up in phonebook if you need help.

Comment 18

[Kevin McCluskey (gone)]

*** This bug has been marked as a duplicate of 97664 ***

Comment 19

[John Unruh]

Verified dupe.

Comment 20

[Stephane Saux]

verified that the simple test case involving a logout before the delete
operation doesn't result in a crash anymore.  Instead the Master pwd is
requested and after providing it the cert is deleted, which is exactly what
would be expected.