958734 - JavaScript Warning: "test for equality (==) mistyped as assignment (=)?" {file: "chrome://browser/content/JSDOMParser.js" line: 782

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Daniel Holbert [:dholbert]]

Noticed this go by in the logcat spew, while running a debug Fennec build today:
{
E/GeckoConsole(25873): [JavaScript Warning: "test for equality (==) mistyped as assignment (=)?" {file: "chrome://browser/content/JSDOMParser.js" line: 782 column: 36 source: "      while (child = this.readNode()) {
}

The code is here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/JSDOMParser.js?rev=7b389768f788#782


Looks like the assignment is intentional. We should just add another layer of parens to silence the warning.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8358656 [details] [diff] [review]
fix

Review of attachment 8358656 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, nice catch.

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/744f49b625e9

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/744f49b625e9