958736 - JavaScript error: app://system.gaiamobile.org/js/lockscreen.js, line 206: this._lockscreenConnInfoManager is null

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Download:

http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/2014-01-10-00-40-09-mozilla-aurora/b2g-28.0a2.multi.mac64.dmg

Extract it and run using:

B2G.app/Contents/MacOS/b2g-bin -profile B2G.app/Contents/MacOS/gaia/profile/

Click Next all the way till Done until the FTU experience is over, then Skip the tutorial.

===

You will hit:

JavaScript error: app://system.gaiamobile.org/js/lockscreen.js, line 206: this._lockscreenConnInfoManager is null

This was also hit here:

https://tbpl.mozilla.org/php/getParsedLog.php?id=32530548&tree=B2g-Inbound&full=1

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

This affects B2G Desktop 1.3 mozilla-aurora and 1.4 mozilla-central (master).

Tested with:

http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/2014/01/2014-01-10-04-02-06-mozilla-central/b2g-29.0a1.multi.mac64.dmg

(One can see this on startup)

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

This still happens with http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/2014/02/2014-02-06-04-02-03-mozilla-central/b2g-30.0a1.multi.mac64.dmg

It will be nice to have this fixed in B2G Desktop (this is one of the few errors remaining). Alive, what is needed to move this forward?

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Arthur mind take a look?

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/16111

We only create a LockScreenConnInfoManager instance when mozMobileConnections is available. Removing the reference to the instance of LockScreenConnInfoManager by moving the localization logic to itself. 

Alive, could you help review it? Thanks!

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks!

master: 31ece334c849d332e1c6053b22789bb9bd7b6a2f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

This broke Marionette-webapi on TBPL. Reverted.
Master: 92d8a3f2de9f0b6310ddb478bcc58015c3c1057a

https://tbpl.mozilla.org/php/getParsedLog.php?id=34473035&tree=B2g-Inbound

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/16193

Alive, mind take a look at it again? The last missed to bind a function I marked in github.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8375300 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/16193

Why does unit test not catch that?

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

It was not covered by the unit tests. Not sure how it got executed. I've already added a test for it.

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: 8ac5dc6b76709e742cb923c58d1f4b415b3e08fb