958741 - IDN support for WebRTC identity

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Martin Thomson [:mt:]]

Bug 884573 introduces identity support, but the identifiers it generates are compared poorly using JavaScript String.prototype.toLowercase().  This should use the IDN ACE conversion before toLowercase(), as used by http://dxr.mozilla.org/mozilla-central/source/netwerk/base/src/nsStandardURL.cpp#1077

Comment 1

[Martin Thomson [:mt:]]

Attachment: 0001-Adding-IDN-support-to-peer-identity-domain-checking.patch

Easy peasy.  Harder to test, but manual tests on nsIIDNService indicate that this is solid.  toACE does normalization and case folding based on what I've tested, so this should be good to roll out.

Comment 2

[Adam Roach [:abr]]

Comment on attachment 8359532 [details] [diff] [review]
0001-Adding-IDN-support-to-peer-identity-domain-checking.patch

Review of attachment 8359532 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, looks good.

Comment 3

[Martin Thomson [:mt:]]

Attachment: 0001-Bug-958741-Adding-IDN-support-to-peerIdentity-name-v.patch

Unbitrotting.  Carrying forward r+ from abr.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dd0f72140555

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dd0f72140555