Closed Bug 958741 Opened 6 years ago Closed 6 years ago

IDN support for WebRTC identity

Categories

(Core :: WebRTC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: mt, Assigned: mt)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 884573 introduces identity support, but the identifiers it generates are compared poorly using JavaScript String.prototype.toLowercase().  This should use the IDN ACE conversion before toLowercase(), as used by http://dxr.mozilla.org/mozilla-central/source/netwerk/base/src/nsStandardURL.cpp#1077
Easy peasy.  Harder to test, but manual tests on nsIIDNService indicate that this is solid.  toACE does normalization and case folding based on what I've tested, so this should be good to roll out.
Assignee: nobody → martin.thomson
Status: NEW → ASSIGNED
Attachment #8359532 - Flags: review?(adam)
Comment on attachment 8359532 [details] [diff] [review]
0001-Adding-IDN-support-to-peer-identity-domain-checking.patch

Review of attachment 8359532 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, looks good.
Attachment #8359532 - Flags: review?(adam) → review+
Unbitrotting.  Carrying forward r+ from abr.
Attachment #8359532 - Attachment is obsolete: true
Attachment #8381589 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/dd0f72140555
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.