95876 - [Buttons] Support <button type="checkbox"/> and "radio" too!

Status: RESOLVED FIXED

(Core :: XUL, defect, P2)

Description

[David Hyatt]

This bug involves several things:
(1) Add a "pushed" property to button and add support for the look to the
skins.
(2) Add a type="push" to allow the button to automatically depress.
(3) Add a type="menu" for completeness (this can be implicitly set by XBL
if a menupopup is attached).
(4) Make sure that a menu button sets and unsets the "pushed" property 
correctly.

Comment 1

[David Hyatt]

--> me

Comment 2

[David Hyatt]

Gonna use type="checkbox" and a .checked property instead of type="push" 
and .pushed.  More consistent with all the other widgets that can have checkbox 
modes and with how editor is using buttons today.

Comment 3

[John Morrison]

May God have mercy on us all. The 212 bug spam-o-rama is Now!

Comment 4

[Joe Hewitt (gone)]

mine

Comment 5

[Joe Hewitt (gone)]

Attachment: patch

Comment 6

[David Hyatt]

Add autoCheck support for both radio and checkbox and remove the mutation event
and the field (mIgnoreetc.).

sr=hyatt. I don't need to see another patch.

Comment 7

[Joe Hewitt (gone)]

Attachment: updated patch

Comment 8

[[e-mail]]

You should use the command handler rather than the checked handler, so that you
don't check disabled buttons by mistake.

Comment 9

[Blake Ross]

r=blake

Comment 10

[Joe Hewitt (gone)]

fixed