Closed Bug 95876 Opened 23 years ago Closed 23 years ago

[Buttons] Support <button type="checkbox"/> and "radio" too!

Categories

(Core :: XUL, defect, P2)

Product:
Core
Component:
XUL
Platform:
x86
Windows 2000
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla0.9.5

People

(Reporter: hyatt, Assigned: hewitt)

References

Details

(Whiteboard: [xul1.0-widgets-button])

Attachments

(2 files)

patch
26.18 KB, patch
Details | Diff | Splinter Review
updated patch
27.29 KB, patch
Details | Diff | Splinter Review 
This bug involves several things:
(1) Add a "pushed" property to button and add support for the look to the
skins.
(2) Add a type="push" to allow the button to automatically depress.
(3) Add a type="menu" for completeness (this can be implicitly set by XBL
if a menupopup is attached).
(4) Make sure that a menu button sets and unsets the "pushed" property 
correctly.
Blocks: 70753
Status: NEW → ASSIGNED
Whiteboard: [xbl1.0-widgets-button]
Target Milestone: --- → mozilla0.9.5
--> me
Assignee: trudelle → hyatt
Status: ASSIGNED → NEW
Gonna use type="checkbox" and a .checked property instead of type="push" 
and .pushed.  More consistent with all the other widgets that can have checkbox 
modes and with how editor is using buttons today.
Status: NEW → ASSIGNED
Whiteboard: [xbl1.0-widgets-button] → [xul1.0-widgets-button]
May God have mercy on us all. The 212 bug spam-o-rama is Now!
QA Contact: aegis → jrgm
mine
Assignee: hyatt → hewitt
Status: ASSIGNED → NEW
Summary: [Buttons] Support pushbutton capabilities → [Buttons] Support <button type="checkbox"/>
Status: NEW → ASSIGNED
Priority: -- → P2
Attached patch patch — — Splinter Review 

    
  
Summary: [Buttons] Support <button type="checkbox"/> → [Buttons] Support <button type="checkbox"/> and "radio" too!

    
    

    
  
Add autoCheck support for both radio and checkbox and remove the mutation event
and the field (mIgnoreetc.).

sr=hyatt. I don't need to see another patch.


    
    

    
  

      
      
      
      

        Attached patch
          
          
        updated patch
        — 
          — Splinter Review
      

    


  

    
    

    
  
You should use the command handler rather than the checked handler, so that you
don't check disabled buttons by mistake.

    
    

    
  
r=blake

    
    

    
  
fixed
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: