95894 - Turbo icon is horked

Status: VERIFIED FIXED

(Core Graveyard :: QuickLaunch (AKA turbo mode), defect)

Description

[Blake Ross]

System tray icons can only support up to 16 colors, hence how bad they currently 
look :-)

Comment 1

[marlon bishop]

is 16 a limitation of the windows system tray, what about the rest of the start 
bar?

Comment 2

[marlon bishop]

are there other icons (plural) needed for system tray?  or just turbo?

Comment 3

[Blake Ross]

All that's needed now is the N for commercial, mozilla's gecko is fine (this
should really be a bugscape bug).

Comment 4

[marlon bishop]

at the moment we have no control over the system tray icon, windows is so 
intelligent, that it just takes and dithers and distorts the application icon. 
so, there is no "system tray icon", just the application icon.  if you come up 
with a way to have one, then that would be great.

Comment 5

[Blake Ross]

mIconData.hIcon =  ::LoadIcon( ::GetModuleHandle( NULL ), IDI_APPLICATION )

MSDN wasn't too helpful in identifying other possible constants besides
IDI_APPLICATION, other than things like IDI_EXCLAMATION and the other standard
win32 msgbox icons.

Bill, any ideas?

Comment 6

[marlon bishop]

Attachment: netscape system tray icon in win 4 bit

Comment 7

[marlon bishop]

what's weird is that the 4bit icon in the App.ico is fine, so i am not sure what 
the deal is.  System tray must be destroying it

Comment 8

[Bill Law]

::LoadIcon probably loads the first image in the icon resource.  When the system
tray gets that, it scales/dithers.  The fix *might* be to use ::LoadImage to
load the properly-sized icon, which the system tray would then use without
screwing it up.

There's an example of the necessary ::LoadImage call at
http://lxr.mozilla.org/seamonkey/source/widget/src/windows/nsWindow.cpp#4612. 
That code loads icons from .ico files, but converting it to load the application
icon from the .exe resource is straightforward.

Comment 9

[Blake Ross]

--> QuickLaunch, because I'm not sure what to do with this. It sure is ugly, though.

Comment 10

[Bill Law]

Blake, did you try loading the icon size 
::GetSystemMetrics(SM_CXSMICON) x ::GetSystemMetrics(SM_CYSMICON)
as I suggested?  I think that should work, but if you tried that, please let me 
know.

->mozilla0.9.9

Comment 11

[Bill Law]

balancing move of Helper App Mgt feature work bugs to this milestone

Comment 12

[Blake Ross]

-> me

Comment 13

[Blake Ross]

Attachment: patch

your idea did work, Bill

Comment 14

[Bill Law]

Comment on attachment 67560 [details] [diff] [review]
patch

r=law

...after you fix the typo and change the second SM_CXSMICON to SM_CYSMICON.

Comment 15

[Blake Ross]

fixed.

Comment 16

[Grace Bush]

verified code fix

Comment 17

[timeless]

QA: this is a real gui bug which should be verified by twiddling with gui settings not by code inspection.