Closed Bug 958992 Opened 6 years ago Closed 6 years ago

http/2 draft 09

Categories

(Core :: Networking: HTTP, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: mcmanus, Assigned: u408661)

References

Details

(Whiteboard: [spdy])

Attachments

(2 files)

this will update the -08 code in the tree but will remain preffed off

nick - can you add the patches here? and then we can work updates in the usual in tree bugzilla driven way
Assignee: nobody → hurley
Whiteboard: [spdy]
Depends on: 890994
OS: Windows 7 → All
Hardware: x86_64 → All
Attached patch draft09 changesSplinter Review
All the updates so support the changes in draft09. Tests are in another patch that will be attached.
Attachment #8359351 - Flags: review?(mcmanus)
And these are the test updates from Gabor. I already reviewed these on github, so this one's ready to go.
Attachment #8359352 - Flags: review+
Comment on attachment 8359351 [details] [diff] [review]
draft09 changes

Review of attachment 8359351 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! ALPN and a successful interop and we can talk about preffing on. followup for placing http/2 in version field of gatewayed responses?

::: netwerk/protocol/http/Http2Compression.cpp
@@ +444,5 @@
> +        mOutput->Append(NS_LITERAL_CSTRING("\r\n"));
> +        mOutput->Append(name);
> +        mOutput->Append(NS_LITERAL_CSTRING(": "));
> +      } else {
> +        mOutput->Append(',');

nit: I guess comma-space would be more typical http/1 syntax
Attachment #8359351 - Flags: review?(mcmanus) → review+
(In reply to Patrick McManus [:mcmanus] from comment #4)
> Comment on attachment 8359351 [details] [diff] [review]
> draft09 changes
> 
> Review of attachment 8359351 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> LGTM! ALPN and a successful interop and we can talk about preffing on.
> followup for placing http/2 in version field of gatewayed responses?

See bug 959333

> ::: netwerk/protocol/http/Http2Compression.cpp
> @@ +444,5 @@
> > +        mOutput->Append(NS_LITERAL_CSTRING("\r\n"));
> > +        mOutput->Append(name);
> > +        mOutput->Append(NS_LITERAL_CSTRING(": "));
> > +      } else {
> > +        mOutput->Append(',');
> 
> nit: I guess comma-space would be more typical http/1 syntax

Done.
You need to log in before you can comment on or make changes to this bug.