958992 - http/2 draft 09

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Patrick McManus [:mcmanus]]

http://tools.ietf.org/html/draft-ietf-httpbis-http2-09 and compression-05

Comment 1

[Patrick McManus [:mcmanus]]

this will update the -08 code in the tree but will remain preffed off

nick - can you add the patches here? and then we can work updates in the usual in tree bugzilla driven way

Comment 2

[u408661]

Attachment: draft09 changes

All the updates so support the changes in draft09. Tests are in another patch that will be attached.

Comment 3

[u408661]

Attachment: draft09 test updates

And these are the test updates from Gabor. I already reviewed these on github, so this one's ready to go.

Comment 4

[Patrick McManus [:mcmanus]]

Comment on attachment 8359351 [details] [diff] [review]
draft09 changes

Review of attachment 8359351 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! ALPN and a successful interop and we can talk about preffing on. followup for placing http/2 in version field of gatewayed responses?

::: netwerk/protocol/http/Http2Compression.cpp
@@ +444,5 @@
> +        mOutput->Append(NS_LITERAL_CSTRING("\r\n"));
> +        mOutput->Append(name);
> +        mOutput->Append(NS_LITERAL_CSTRING(": "));
> +      } else {
> +        mOutput->Append(',');

nit: I guess comma-space would be more typical http/1 syntax

Comment 5

[u408661]

(In reply to Patrick McManus [:mcmanus] from comment #4)
> Comment on attachment 8359351 [details] [diff] [review]
> draft09 changes
> 
> Review of attachment 8359351 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> LGTM! ALPN and a successful interop and we can talk about preffing on.
> followup for placing http/2 in version field of gatewayed responses?

See bug 959333

> ::: netwerk/protocol/http/Http2Compression.cpp
> @@ +444,5 @@
> > +        mOutput->Append(NS_LITERAL_CSTRING("\r\n"));
> > +        mOutput->Append(name);
> > +        mOutput->Append(NS_LITERAL_CSTRING(": "));
> > +      } else {
> > +        mOutput->Append(',');
> 
> nit: I guess comma-space would be more typical http/1 syntax

Done.

Comment 6

[u408661]

try run: https://tbpl.mozilla.org/?tree=Try&rev=c9ffa58a0fee

Comment 7

[u408661]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/5475b2719136
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/b114534a9386

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5475b2719136
https://hg.mozilla.org/mozilla-central/rev/b114534a9386